Repository navigation
Compute v2: Adding Migrate Action - #444
Merged
Merged
Conversation
Contributor
Author
|
@jrperritt ping for review. No rush, though. |
jrperritt
reviewed
Aug 23, 2017
| ) | ||
|
|
||
| // Migrate will initiate a migration of the instance to another host. | ||
| func Migrate(client *gophercloud.ServiceClient, id string) (r gophercloud.ErrResult) { |
Contributor
There was a problem hiding this comment.
Can we return a MigrateResult instead?
Contributor
Author
There was a problem hiding this comment.
We certainly can. I'll get this cleaned up soon and ping.
Contributor
Author
|
@jrperritt ping |
jrperritt
approved these changes
Aug 24, 2017
msheikh-wind
pushed a commit
to msheikh-wind/gophercloud
that referenced
this pull request
May 19, 2025
…ophercloud#444) This commit replaces gcr.io/kubebuilder/kube-rbac-proxy for metrics protection in favor of builtin controller-runtime [1] features to protect the metrics endpoint and to serve certificates. As requirement, this commit: - Upgrades the controller-runtime - Upgrades Golang to 1.23 as requirement of controller-runtime - Replaces kube-rbac-proxy protection with controller-runtime feature - Serves metrics endpoint certificates with certmanager [2] - Upgrades tests Ginkgo tooling [1]: https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/certwatcher [2]: https://cert-manager.io/ Test Plan: - PASS: Build a new Helm chart - PASS: Build a new Docker image - PASS: Deploy a AIO-SX with the image built - Validate the metrics endpoint are serving - Validate the webhook validations - Validate day-2 operations Signed-off-by: Wallysson Silva <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #82
Supersedes #84
https://github.com/openstack/nova/blob/77b11a9e31e265c338857326418bfe8cd135c1f8/nova/api/openstack/compute/migrate_server.py
Note that this only implements what would be handled in the
_migratefunction, not the_migrate_livefunction.