Repository navigation
SharedFileSystems v2: Restrict ExtractExportLocations to only GetExportLocationsResults - #449
Merged
jrperritt merged 3 commits intoAug 11, 2017
Conversation
…rtLocationsResults
jrperritt
reviewed
Aug 11, 2017
| // GetExportLocationsResult contains the result body and error from an | ||
| // GetExportLocations request. | ||
| type GetExportLocationsResult struct { | ||
| commonResult |
Contributor
There was a problem hiding this comment.
This isn't a commonResult, is it? Does it return a Share in addition to an ExportLocation? If not, why should the method below stay ExtractExportLocations instead of Extract?
Contributor
Author
|
All good questions. Thank you. |
jrperritt
reviewed
Aug 11, 2017
| // GetExportLocationsResult contains the result body and error from an | ||
| // GetExportLocations request. | ||
| type GetExportLocationsResult struct { | ||
| gophercloud.Result |
jobrs
pushed a commit
to sapcc/gophercloud
that referenced
this pull request
Aug 17, 2017
…rtLocationsResults (gophercloud#449) * SharedFileSystems v2: Restrict ExtractExportLocations to only GetExportLocationsResults * SharedFileSystems v2: Further changes to ExportLocations results * SharedFileSystems v2: Fix comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #448