Skip to content

BlockStorage v2: Fix small issues with volumeactions - #452

Merged
jrperritt merged 1 commit into
gophercloud:masterfrom
jtopjian:bsv2-volumeattach-fixes
Aug 11, 2017
Merged

jrperritt merged 1 commit into
gophercloud:masterfrom
jtopjian:bsv2-volumeattach-fixes

Conversation

@jtopjian

Copy link
Copy Markdown
Contributor

For #451

This commit fixes two small issues found in the volumeactions
package:

1. ExtendSize does not return a body. Prior to this patch, an
EOF error was returned.

2. commonResult was being used only for InitializeConnection
which is not really common.
@coveralls

coveralls commented Aug 11, 2017 •

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 71.492% when pulling 52f5e13 on jtopjian:bsv2-volumeattach-fixes into 4ecdf7c on gophercloud:master.

@jrperritt jrperritt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrperritt
jrperritt merged commit ea69935 into gophercloud:master Aug 11, 2017
@jtopjian
jtopjian deleted the bsv2-volumeattach-fixes branch April 24, 2018 03:13
cardoe pushed a commit to cardoe/gophercloud that referenced this pull request Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants