Repository navigation
Compute v2: Clean up diskconfig package - #471
Merged
jrperritt merged 1 commit intoNov 4, 2017
Merged
Conversation
jtopjian
force-pushed
the
computev2-diskconfig-cleanup
branch
from
September 8, 2017 04:13
4ef61ad to
4e91496
Compare
Contributor
Author
|
@jrperritt ping for review. Unit test has been added now that #466 was merged. |
This was referenced Nov 4, 2017
cardoe
pushed a commit
to cardoe/gophercloud
that referenced
this pull request
Aug 27, 2020
Fix OpenStack single volume attach example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #470
For #446
A unit test for the extension can be added after #466 is merged since it modifies the same area of code. I tested it locally and it works as expected.