Repository navigation
GFQL monolith shrinkdown S2: extract bounded reentry glue from lowering.py #1295
Description
Summary
Execution slice S2 under #1260.
Extract bounded reentry planning/runtime glue out of lowering.py into focused module(s), preserving behavior and test parity.
Scope
In scope:
- Move bounded reentry planning helpers to dedicated module(s)
- Reduce
lowering.pysurface for reentry-specific logic - Keep public behavior and contracts unchanged
Out of scope:
- Full
lowering.pyconcern split (S3) - Feature additions
Acceptance
- Reentry glue extracted to focused module(s) with clear ownership boundaries.
lowering.pyLOC reduced materially (report delta in Meta: GFQL monolith shrinkdown (lowering.py + CompiledCypher cleanup) #1260).- Reentry and cypher lowering tests remain green.
- No regressions in
#1263/#1275/#1285landed behaviors.
Activity
refactor(cypher): extract bounded reentry glue from lowering.py (#1295)
refactor(cypher): extract bounded reentry glue from lowering.py (#1295)…
lmeyerov commentedon May 5, 2026
Closure-ready.
Landed: #1299 squash-merged at master
373b55fd8(2026-05-05).Acceptance check:
graphistry/compute/gfql/cypher/reentry/subpackage withnaming.py/scope.py/carry.py/rewrite.py, with__all__declared in each.lowering.pyLOC reduced materially — 17 helpers (16 public + carry-internal_literal_limit_value, ~470 LOC) moved out. Combined with Refactor #1294: retire dual-contract reentry extras path #1297 (GFQL monolith shrinkdown S1: retire dual-contract reentry extras path #1294 S1) the file shrunk from 10,192 → 9,659 LOC (−533) by the time both landed.tests/compute/gfql/cypher/+tests/compute/test_gfql.py: 1244 passed, 92 skipped, 15 xfailed, 0 failed post-merge.Out of scope (deferred to a follow-on slice under #1260):
_compile_bounded_reentry_query(orchestrator) and_map_terminal_reentry_queryleft inlowering.py. Both shared Refactor #1294: retire dual-contract reentry extras path #1297 hot edit surface; deferring them to a follow-on slice was the additive/refactor-only guardrail that let GFQL monolith shrinkdown S1: retire dual-contract reentry extras path #1294 (PR Refactor #1294: retire dual-contract reentry extras path #1297) and GFQL monolith shrinkdown S2: extract bounded reentry glue from lowering.py #1295 (PR Refactor #1295: extract bounded reentry glue from lowering.py #1299) land independently in the same release window.External imports preserved:
gfql_unified.py:35andtests/test_gfql.py:8continue to import_reentry_hidden_column_namefromcypher.loweringvia re-export — no caller changes needed.OK to close at coordinator's discretion.
lmeyerov commentedon May 5, 2026
Closing as completed via PR #1299 (squash merge 373b55f). Coordinator receipt: #1260 S2 complete; follow-on slices S3/S4/S5 remain under #1260.
refactor(verifier): consolidate inline nullability checks onto is_nul…
refactor(verifier): consolidate inline nullability checks onto is_nul…
refactor(verifier): consolidate inline nullability checks onto is_nul…
T3 #1300: type/null metadata propagation contract for BoundIR/Logical…