Skip to content

Tranche: Temporal wrong-row semantics (14 cases) under #1353 #1365

Description

@lmeyerov

Summary

One-PR tranche under meta-issue #1353: resolve temporal wrong-row semantics in direct-Cypher execution.

Current bucket size: 14 wrong-row cases.

Scope (keys)

  • expr-temporal7-1-1
  • expr-temporal7-1-2
  • expr-temporal7-2-1
  • expr-temporal7-2-2
  • expr-temporal7-3-1
  • expr-temporal7-3-2
  • expr-temporal7-4-1
  • expr-temporal7-4-2
  • expr-temporal7-5-1
  • expr-temporal7-5-2
  • expr-temporal7-6-8
  • expr-temporal6-6-2
  • expr-temporal6-6-8
  • expr-temporal2-6-5

Why this tranche

  • High practical impact (temporal filters/sorts/comparisons are common).
  • Dense cluster likely sharing comparator/canonicalization logic.
  • One PR size is realistic and measurable.

Acceptance criteria

  • All listed keys move from success_wrong_rows to success_matches_expected.
  • unexpected_success_expected_error does not increase.
  • No regression in direct-cypher support snapshot and focused tck contract checks.
  • Keep semantics vectorized and cuDF-compatible.

Repro

  • PYTHONPATH=/home/lmeyerov/Work/pygraphistry:/home/lmeyerov/Work/tck-gfql UV_EXCLUDE_NEWER="6 days" uv run --python 3.13 --no-project --with pytest --with pandas python -m pytest -q tests/cypher_tck/test_tck_runner.py -k "test_direct_cypher_xfail_contract"
  • PYTHONPATH=/home/lmeyerov/Work/pygraphistry:/home/lmeyerov/Work/tck-gfql UV_EXCLUDE_NEWER="6 days" uv run --python 3.13 --no-project --with pytest --with pandas python -m tests.cypher_tck.report

Cross-reference

Activity

  1. lmeyerov commented on May 9, 2026

    @lmeyerov
    ContributorAuthor

    Marking this as the active next tranche from #1353.\n\nExecution protocol initialized with:\n- keyset lock (14 temporal wrong-row keys)\n- acceptance criteria (move to success_matches_expected, no increase in unexpected_success_expected_error)\n- tck contract/report repro commands\n- DGX-only cuDF validation commands for runtime changes\n\nNext implementation step is pygraphistry branch work scoped to this issue only.

  2. lmeyerov commented on May 9, 2026

    @lmeyerov
    ContributorAuthor

    Update: tck-side false-negative subset for this tranche is now in PR graphistry/tck-gfql#40 (issue #38).\n\nThis fixes 10 Temporal7 expected-row placeholder artifacts (literal ), moving those keys from success_wrong_rows to success_matches_expected in tck-gfql once merged.\n\nAfter that lands, #1365 should retain the true pygraphistry semantics keys: expr-temporal2-6-5, expr-temporal6-6-2, expr-temporal6-6-8, expr-temporal7-6-8.

  3. lmeyerov commented on May 9, 2026

    @lmeyerov
    ContributorAuthor

    Closing as duplicate/superseded by #1361 + #1364 for this temporal tranche.

  4. lmeyerov commented on May 9, 2026

    @lmeyerov
    ContributorAuthor

    Superseded by completed concrete tracker #1361 and merged PR #1364 (temporal tranche landed; 13/14 fixed, 1 deferred Stockholm historical TZ edge). Closing this duplicate tranche issue to keep #1353 bookkeeping single-sourced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions