Tranche: mixed wrong-row tail cleanup under #1353

Summary

One-PR tranche under meta-issue #1353: remaining mixed wrong-row tail after core expression/temporal fixes.

Current bucket size: 10 wrong-row cases.

Scope (keys)

expr-aggregation3-1
expr-mathematical8-1
expr-mathematical8-2
expr-pattern1-10
match5-8
match5-25
match5-26
return2-9
return2-10
with2-1

Why this tranche

Small, diverse tail appropriate for one cleanup PR once core tranches land.
Enables meta-issue closeout sequencing.

Acceptance criteria

Listed keys move from success_wrong_rows to success_matches_expected, or are split out with justified follow-up issues if architectural.
No increase in unexpected_success_expected_error.
Focused contract checks remain green.

Repro

PYTHONPATH=/home/lmeyerov/Work/pygraphistry:/home/lmeyerov/Work/tck-gfql UV_EXCLUDE_NEWER="6 days" uv run --python 3.13 --no-project --with pytest --with pandas python -m pytest -q tests/cypher_tck/test_tck_runner.py -k "test_direct_cypher_xfail_contract"

Cross-reference

Parent meta-issue: Meta: Prioritized direct-Cypher wrong-row bugfix tranches (92 cases) #1353

#1369 closeout lane status: PR ready, merge review-gated.

Receipts:

pygraphistry PR: [codex] Fix Cypher zero-hop and empty post-aggregate rows #1443
pygraphistry branch: issue-1369-mixed-wrong-row-tail @ 9d8e9168
companion TCK branch: graphistry/tck-gfql@issue-1369-mixed-wrong-row-tail @ e8c2bda
PR CI: green after rerunning both tck-gfql jobs against the same-named sibling branch:
- run 25905424171, job 76139761979: passed in 4m26s
- run 25905425448, job 76139762611: passed in 4m55s
Review skill: reconverged after 4 waves, final report has 0 blocker / 0 important / 0 suggestions.

Local validation:

Tranche: mixed wrong-row tail cleanup under #1353 #1369 focused pygraphistry regressions: 2 passed
hop/Cypher focused cluster: 10 passed, 999 deselected
ruff on touched Python files: passed
typecheck: passed
surface guard: passed after intentional baseline bump to 9003 lines
sibling tck-gfql ./bin/ci.sh: 3935 passed, 766 xfailed

Implemented:

Cypher exact *0..0 relationships now preserve the seed node as the zero-length path.
Public hop(..., 0) behavior remains unchanged via a default-false internal seed flag.
Empty-graph post-aggregate expression projection now materializes the final return column/value, e.g. MATCH (a) RETURN count(a) > 0.
CHANGELOG.md updated.

Residual #1369 state after this lane:

Fixed/promoted: match5-8, return2-10
Already matching current sibling snapshot: expr-aggregation3-1, expr-mathematical8-1, expr-mathematical8-2
Still wrong-row / follow-up: expr-pattern1-10, match5-25, match5-26, return2-9, with2-1

Merge status:

Direct merge was attempted, but GitHub rejected it: base branch policy requires review.
Auto-merge was attempted, but repository auto-merge is disabled.
Next maintainer action: approve and merge PR [codex] Fix Cypher zero-hop and empty post-aggregate rows #1443. Do not close this issue until PR [codex] Fix Cypher zero-hop and empty post-aggregate rows #1443 is merged.

#1369 post-merge receipt.

Merged:

pygraphistry [codex] Fix Cypher zero-hop and empty post-aggregate rows #1443: [codex] Fix Cypher zero-hop and empty post-aggregate rows #1443
Merge commit: f8d02053d5501565bef65befb469d2f7ddd85afb
Merged at: 2026-05-15T16:48:37Z
Merged head: 90aebc74d1bad392f046f1d4741b9b8116500e4a
Base at merge: origin/master @ 79d62aa5a48da07f1d83bb3b6c894a19754b77cf

What landed:

Exact Cypher *0..0 variable-length relationships now preserve the seed node as a zero-length path.
Public hop(..., 0) behavior remains unchanged via a default-false internal seed flag.
Empty-graph post-aggregate expression projection now emits the final return column/value.
Amplification found and fixed sibling post-aggregate expression temp-name collisions.
CHANGELOG.md, tests, and Cypher surface-guard baseline were updated.

Validation:

Post-rebase local checks passed: git diff --check, focused Tranche: mixed wrong-row tail cleanup under #1353 #1369 pytest, ruff touched files, Cypher surface guard, broader hop/Cypher cluster.
DGX RAPIDS 25.02 focused cuDF rerun: 2 passed.
DGX RAPIDS 26.02 focused cuDF rerun: 2 passed.
GitHub CI green at merge: 136 success, 1 skipped.
Review skill reconverged before merge: 6 waves total, 0 blocker / 0 important / 0 suggestions.

Current #1369 state:

Keep this issue open for now.
Fixed/promoted by this lane: match5-8.
return2-10 was already current-main compatible and promoted by tck-gfql#109, and this lane kept it validated.
Already matching current sibling snapshot: expr-aggregation3-1, expr-mathematical8-1, expr-mathematical8-2.
Remaining residual wrong-row/follow-up keys: expr-pattern1-10, match5-25, match5-26, return2-9, with2-1.

Coordinator handoff:

No open PR exists for graphistry/tck-gfql@issue-1369-mixed-wrong-row-tail as of this update.
Next useful action is either a sidecar contract PR/re-snapshot, or splitting the five remaining residual keys into narrower follow-ups.

#1369 sidecar/split lane update.

Opened the missing tck-gfql sidecar PR:

Promote match5-8 direct Cypher contract tck-gfql#112: Promote match5-8 direct Cypher contract tck-gfql#112
Head: issue-1369-mixed-wrong-row-tail @ 7a3f108c63c612769dafd696390520e054e7dbe8
Base: main @ eb703f6de7abab356199b6938019886e3bcb5b1f

What #112 does:

Rebases the existing sidecar branch onto current tck-gfql main.
Promotes match5-8 from success_wrong_rows to success_matches_expected after pygraphistry [codex] Fix Cypher zero-hop and empty post-aggregate rows #1443 fixed exact zero-hop *0..0 Cypher relationship semantics.
Keeps the already-merged Dev/neo4j tuning #109 promotions for expr-list12-3 and return2-10.

Fresh report after the sidecar:

tracked non-validation debt: 9
success_matches_expected: 1 (match5-8)
success_wrong_rows: 7
unexpected_success_expected_error: 1

Remaining residuals from the fresh report:

Pattern expression wrong rows: expr-pattern1-10, expr-pattern1-13, expr-pattern1-18
Match fixture/semantic wrong rows: match5-25, match5-26
Row-shape wrong row: return2-9
WITH join/setup wrong row: with2-1
Expected-error drift: expr-list1-6-4

Validation:

Focused sidecar contract/report tests: 8 passed.
Full sidecar CI locally: 3935 passed, 763 xfailed.
GitHub CI for Promote match5-8 direct Cypher contract tck-gfql#112: green (tests passed in 4m4s).
Review skill converged after 2 waves: 0 blocker / 0 important / 0 suggestions.
DGX/RAPIDS skipped for Dev/demo reorg 2 #112 because it changes only tck-gfql contract/report/changelog bookkeeping; pygraphistry runtime/GPU evidence was already recorded on [codex] Fix Cypher zero-hop and empty post-aggregate rows #1443.

Current status:

Keep Tranche: mixed wrong-row tail cleanup under #1353 #1369 open until Promote match5-8 direct Cypher contract tck-gfql#112 merges and the remaining residuals are split/assigned.
Recommended post-Dev/demo reorg 2 #112 split: separate follow-ups for pattern-expression duplicate/missing rows, match5-25/26 fixture-or-semantics resolution, return2-9 duplicate map row cardinality, with2-1 WITH-pipelined join/setup behavior, and expr-list1-6-4 expected-error drift.

#1369 merged sidecar and split closeout.

Merged sidecar:

Promote match5-8 direct Cypher contract tck-gfql#112: Promote match5-8 direct Cypher contract tck-gfql#112
Merge commit: cabc23b6587d97542346826cb848c06a95c226fa
Merged at: 2026-05-15T17:49:35Z
CI: tests passed in 4m4s

Post-merge report against:

pygraphistry origin/master @ f8d02053d5501565bef65befb469d2f7ddd85afb
tck-gfql origin/main @ cabc23b6587d97542346826cb848c06a95c226fa

Fresh post-merge state:

tracked non-validation debt: 9
success_matches_expected: 1 (match5-8)
success_wrong_rows: 7
unexpected_success_expected_error: 1

Split residual follow-ups:

Direct-Cypher residual: pattern predicate wrong rows under #1369 #1449 — pattern predicate wrong rows: expr-pattern1-10, expr-pattern1-13, expr-pattern1-18
Direct-Cypher residual: string list-index expected-error drift under #1369 #1450 — string list-index expected-error drift: expr-list1-6-4
Direct-Cypher residual: reconcile return2-9 map row cardinality tck-gfql#113 — return2-9 map row cardinality contract
Direct-Cypher residual: reconcile match5-25/26 fixture or contract tck-gfql#114 — match5-25 / match5-26 fixture or contract reconciliation
Direct-Cypher residual: reconcile with2-1 setup/join contract tck-gfql#115 — with2-1 setup/join contract reconciliation

Validation receipts:

Sidecar local focused tests before merge: 8 passed
Sidecar full local CI before merge: 3935 passed, 763 xfailed
Sidecar GitHub CI: green
Review skill: converged after 2 waves, 0 blocker / 0 important / 0 suggestions
Post-merge report rerun completed and matches the split list above

Closing #1369: the original mixed-tail tranche is now resolved by landed runtime work (#1443), merged sidecar bookkeeping (#112), and explicit split follow-up issues for the remaining residuals.

Closed after merged pygraphistry #1443, merged sidecar graphistry/tck-gfql#112, fresh post-merge report rerun, and residual split into #1449, #1450, and graphistry/tck-gfql#113/#114/#115.

Navigation Menu

Repository navigation

Tranche: mixed wrong-row tail cleanup under #1353 #1369

Summary

Scope (keys)

Why this tranche

Acceptance criteria

Repro

Cross-reference

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Tranche: mixed wrong-row tail cleanup under #1353 #1369

Description

Summary

Scope (keys)

Why this tranche

Acceptance criteria

Repro

Cross-reference

Activity

lmeyerov commented on May 15, 2026

lmeyerov commented on May 15, 2026

lmeyerov commented on May 15, 2026

lmeyerov commented on May 15, 2026

lmeyerov commented on May 15, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions