Repository navigation
Conversation
This was referenced Apr 2, 2026
lmeyerov
force-pushed
the
fix/issue-1000-reentry-match-where-with
branch
from
April 2, 2026 17:17
2b873c1 to
78c12e6
Compare
lmeyerov
force-pushed
the
fix/issue-1000-dynamic-pattern-properties
branch
from
April 3, 2026 03:18
5baaf5e to
2a50cfc
Compare
lmeyerov
force-pushed
the
fix/issue-1000-reentry-match-where-with
branch
from
April 3, 2026 03:18
a3053e5 to
024a2bc
Compare
lmeyerov
marked this pull request as ready for review
April 3, 2026 08:01
lmeyerov
merged commit Apr 3, 2026
7dd52df
into
fix/issue-1000-dynamic-pattern-properties
146 of 177 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MATCH ... WITH ... MATCH ... WHERE ... WITH ... MATCH ... RETURNWHEREto the correct current reentry stage during bounded reentry compilation#1000IC6 query past the earlier post-reentry-WHEREparser barrier to the nextUNWIND after post-WITH MATCHblockerMATCHafter post-WITH WHEREand multi-WHEREreentry shapes still fail fast explicitlyScope
This is Phase 2 of
#1000, stacked on top of Phase 1 PR#1027.What it covers:
MATCH ... WITH ... MATCH ... WHERE ... WITH ... MATCH ... RETURNWHERE ... WITHreentry pathWHEREto post-reentryUNWINDWhat it does not cover yet:
UNWINDbetween reentry stagespostLinks
Amplification notes
The follow-on coverage on this branch also locks the intended fail-fast boundaries around the parser state change:
MATCHafter post-WITH WHEREis still rejectedWHEREclauses are still rejected explicitlyTesting
python3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'multi_stage_with_match_reentry_connected_shape or multi_stage_with_match_reentry_carried_scalar_shape or multi_stage_with_match_reentry_with_intermediate_where or failfast_rejects_direct_match_after_post_with_where_without_intervening_with or failfast_rejects_multiple_post_with_where_clauses or issue_1000_ic6_after_phase2_now_stops_at_post_with_match_unwind'python3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'same_path_expression_valued_pattern_property or non_property_dynamic_pattern_expression_runtime or reentry_identifier_valued_pattern_property or reentry_relationship_expression_valued_pattern_property'ruff check graphistry/compute/gfql/cypher/parser.py graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_lowering.py