Repository navigation
Conversation
This was referenced Apr 2, 2026
lmeyerov
force-pushed
the
fix/issue-1000-prefix-scalar-reentry
branch
from
April 3, 2026 03:18
5a5e9da to
e112f8a
Compare
lmeyerov
force-pushed
the
fix/issue-1000-reentry-comma-fanout
branch
from
April 3, 2026 03:19
c79d102 to
2e08dd5
Compare
lmeyerov
force-pushed
the
fix/issue-1000-reentry-comma-fanout
branch
from
April 3, 2026 04:09
9a1b30e to
4c99a9a
Compare
lmeyerov
marked this pull request as ready for review
April 3, 2026 08:02
lmeyerov
merged commit Apr 3, 2026
12eb3ae
into
fix/issue-1000-prefix-scalar-reentry
99 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1000
Stacked on #1034.
This Phase 6a slice turns the earlier comma-fanout blocker into a runtime fix. Connected non-linear comma
MATCHshapes now lower through joined bindings rows instead of the old single-linear-path normalizer.What's included:
count(post), direct non-reentry fanout execution, and cuDF parity coverageCHANGELOG.mdprepWhat remains adjacent but separate:
group by one alias, aggregate anotheron already-linear connected fanout shapes)Focused validation run locally on April 2, 2026:
python3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "connected_star_comma_fanout or issue_1000_ic6_compiles_after_phase6_connected_star_fanout or connected_multi_pattern_grouped_aggregate_overlap or scalar_only_prefix_with_match_reentry"->12 passed, 2 skipped, 632 deselectedpython3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "connected_multi_pattern or connected_star_comma_fanout or scalar_only_prefix_with_match_reentry or multiple_post_with_where_clauses or post_with_match_collect_unwind_match or issue_1000_ic6_compiles_after_phase6_connected_star_fanout"->30 passed, 4 skipped, 612 deselectedpython3.12 -B -m pytest -q graphistry/tests/compute/gfql/cypher/test_parser.py -k "reentry or unwind"->11 passed, 84 deselectedruff check graphistry/compute/gfql/cypher/lowering.py graphistry/compute/gfql_unified.py graphistry/tests/compute/gfql/cypher/test_lowering.py graphistry/tests/compute/gfql/cypher/test_parser.py-> passedTargeted dgx-spark note:
cudaErrorMemoryAllocation/std::bad_allocwhile constructing a tiny cuDF frame, so that result was operationally inconclusive rather than a clear product failure