Repository navigation
Remove connected optional compat fallback - #1435
Merged
Merged
Conversation
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #1418.
Finishes the next narrow D1 deletion after #1431: connected OPTIONAL MATCH plans now dispatch directly from the physical-plan path before generic same-path/row-pipeline compatibility dispatch, matching the connected MATCH cutover. The stale
connected_optional_matchbranch is removed from_execute_compiled_query_compat_non_union.This is still a conservative pygraphistry source cleanup. It does not close #1415, #1416, or #880 by itself; those remain benchmark/evidence closeout gates.
Validation
/tmp/tck-gfql-ci-venv312/bin/python -m pytest -q graphistry/tests/compute/gfql/test_runtime_physical_cutover.py graphistry/tests/compute/gfql/test_physical_planner.py/tmp/tck-gfql-ci-venv312/bin/python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py::test_connected_optional_query_sets_query_graph_and_logical_plan graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_996_connected_match_optional_match_simple_projection graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_996_connected_match_optional_match_case_null graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_996_no_optional_matches graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_996_two_shared_node_aliases graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_996_integer_node_ids graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_996_custom_node_column_name graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_996_longer_optional_chain graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1024_where_not_pattern_on_optional_match_filters_candidates graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1024_where_not_pattern_on_optional_match_null_fills_when_all_filtered graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1025_two_optional_match_clauses graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1025_two_optional_match_one_misses graphistry/tests/compute/gfql/cypher/test_lowering.py::test_audit_chained_optionals_share_non_base_alias graphistry/tests/compute/gfql/cypher/test_lowering.py::test_audit_multi_optional_order_by_limit/tmp/tck-gfql-ci-venv312/bin/python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "connected_optional or issue_996 or issue_1024 or issue_1025"./bin/ruff.sh graphistry/compute/gfql_unified.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.pygit diff --checkReview
Review skill converged with two clean waves and no findings.