Repository navigation
Route Cypher CALL through physical dispatch - #1458
Merged
Merged
Conversation
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1455.
This inventories the remaining D5 compat fallback routes and makes the CALL route decision concrete:
procedure_callphysical route viaProcedureCallExecutorWrapper.CALLthrough physical planning, thenexecute_cypher_call()plus the existing chain continuation._execute_compiled_query_compat_non_union().logical_plan is Nonefallback families for top-levelOPTIONAL MATCHand optional reentry.Route Matrix
CALL graphistry.*procedure_callphysical routeGRAPH { CALL ...write() }constructorOPTIONAL MATCHwithout logical planValidation
python3 -m pytest -q graphistry/tests/compute/gfql/test_physical_planner.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.py->16 passedpython3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "not cudf and (logical_plan_route or compile_cypher_call_returns_procedure_program or string_cypher_executes_graphistry_call)"->32 passed, 2 skippedpython3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "not cudf"->936 passed, 12 skipped, 111 deselected./bin/ruff.sh ...changed files...-> greengit diff --check-> cleanssh dgx-sparkRAPIDS 25.02 GFQL package suite ->2357 passed, 22 skipped, 15 xfailedssh dgx-sparkRAPIDS 26.02 GFQL package suite ->2357 passed, 22 skipped, 15 xfailedLocal note: direct
./bin/test-minimal-lite.shcannot start here because the shell only haspython3; reran with a temporarypythonPATH shim. Local broad sentinel still hits no-CUDA cuDF/CuPy/UMAP paths, so cuDF validation was completed on DGX.Review Skill
Review protocol artifacts are local under
plans/d5-compat-fallback-inventory-1455/:research/context.mdresearch/policies.mdresearch/credentials.mdwaves/wave-1/wave-report.mdwaves/wave-2/wave-report.mdfinal-report.mdResult: two clean/no-advance waves; no BLOCKER or IMPORTANT findings remain.
Sibling TCK
graphistry/tck-gfqlsibling PR fix(plotter): respect client_protocol_hostname for full_url #122 is now closed as empty because currenttck-gfql/mainalready contains the needed rebaseline.tck-gfqlbranch still exists and points at currentmain, so pygraphistry PR CI resolves cleanly.tck-gfqlpush-run check; current Route Cypher CALL through physical dispatch #1458 check rollup is green.