Repository navigation
Delete obsolete M1 differential scaffold tests - #1491
Merged
Merged
Conversation
lmeyerov
force-pushed
the
issue-1472-delete-m1-diff-scaffold
branch
from
May 17, 2026 16:58
06313e9 to
6a80735
Compare
This was referenced May 17, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1472.
Summary
OPTIONAL MATCHrow/null behavior as a direct lowering test, including both optional-clause orders.CHANGELOG.md.Audit
ic1-independent-optional-armsand reversed order: promoted to directtest_issue_1472_independent_optional_arms_preserve_per_row_nulls.with-boundary-binding-row-regression: already covered by direct runtimetest_issue_1047_multi_row_scalar_prefix_both_tags_matchedand binder lineagetest_binder_with_boundary_scope_lineage.test_compile_cypher_invokes_binder_prepass,test_compile_cypher_rebinds_after_normalization, andtest_cypher_to_gfql_invokes_binder_prepass.test_binder_optional_match_tracks_null_extended_fromand direct optional-only alias detection tests.LOC delta
CHANGELOG.md: +1 / -0graphistry/tests/compute/gfql/cypher/test_lowering.py: +41 / -0graphistry/tests/compute/gfql/cypher/test_m1_differential_scaffold.py: +0 / -282Validation
python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1472_independent_optional_arms_preserve_per_row_nulls graphistry/tests/compute/gfql/cypher/test_binder.py::test_binder_optional_match_tracks_null_extended_from graphistry/tests/compute/gfql/cypher/test_binder.py::test_binder_with_boundary_scope_lineage graphistry/tests/compute/gfql/cypher/test_lowering.py::test_issue_1047_multi_row_scalar_prefix_both_tags_matched5 passed, 4 warningspython3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_binder.py graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'not cudf'1022 passed, 12 skipped, 113 deselected, 65 warnings./bin/ruff.sh./bin/typecheck.shgit diff --checkGPU/RAPIDS note
This PR is a test-only deletion/preservation slice and does not change cuDF/GPU runtime code. The full local binder/lowering command without
-k 'not cudf'hit local environment failures becausecudfis installed but no CUDA device is present (cudaErrorNoDevice); the non-cuDF slice and focused replacement tests pass locally.CI note
The pygraphistry
tck-gfqlworkflow resolves a same-namedgraphistry/tck-gfqlbranch before falling back tomain. A matchingissue-1472-delete-m1-diff-scaffoldTCK branch was created at the open with5-2 rebaseline PR head (graphistry/tck-gfql#128) so this PR uses the current direct-Cypher expectation while that TCK baseline is awaiting merge.