Repository navigation
GFQL deletion: remove obsolete M1 differential scaffold legacy-baseline tests #1472
Description
Activity
#1472 implementation status:
- PR: Delete obsolete M1 differential scaffold tests #1491
- Deleted obsolete M1 legacy-vs-candidate differential scaffold test file.
- Preserved the unique independent
OPTIONAL MATCHrow/null behavior as direct lowering coverage across both optional-clause orders. - No runtime/compiler behavior changed.
- LOC delta:
CHANGELOG.md+1/-0,test_lowering.py+41/-0,test_m1_differential_scaffold.py+0/-282; net +42/-282, overall -240 LOC. - Local validation: focused preservation tests passed; binder/lowering non-cuDF slice passed (
1022 passed);./bin/ruff.sh,./bin/typecheck.sh, andgit diff --checkpassed. - Review skill converged after two no-finding waves.
- CI is green on current PR head. GPU/RAPIDS was not run because this is a test-only deletion/preservation slice with no cuDF/GPU runtime changes; local full cuDF collection is blocked on the non-GPU host by
cudaErrorNoDevice.
#1472 merged.
- PR: Delete obsolete M1 differential scaffold tests #1491
- Merge commit:
adc2912c80d7284dc5aeb62acea1c8082fb629ce - Conflict resolution: rebased onto
origin/masterd0d66d517c45e6df87d1724f0720d2e964f21952; resolvedCHANGELOG.mdby keeping both the new GFQL deletion: native-plan shortestPath/path-alias multiple MATCH residuals #1489 entry and the GFQL deletion: remove obsolete M1 differential scaffold legacy-baseline tests #1472 deletion entry under[Development] / Changed. - Scope: deleted obsolete M1 legacy-vs-candidate differential scaffold; preserved unique independent
OPTIONAL MATCHrow/null behavior as direct lowering coverage across both optional-clause orders; no runtime/compiler behavior changes. - LOC delta:
+42 / -282, net-240. - Validation after rebase: focused GFQL deletion: remove obsolete M1 differential scaffold legacy-baseline tests #1472 preservation tests passed (
5 passed, 4 warnings);git diff --check origin/master...HEADpassed before merge. - Merge path: admin override used as requested. PR was mergeable after conflict resolution; review/branch-protection was the remaining blocker and fresh checks had been requeued by the rebase push.
Summary
graphistry/tests/compute/gfql/cypher/test_m1_differential_scaffold.pystill carries an M1-era legacy-vs-candidate differential scaffold. The strict binder/runtime rollout has since landed, so this test harness should be audited for deletion or replacement by direct conformance tests.Current evidence
On current
origin/master:test_m1_differential_scaffold.pydefines_run_legacy()and compares binder-prepass/candidate behavior against legacy behavior.test_diff_corpus_legacy_baselineandtest_diff_corpus_legacy_vs_candidate.Goal
Delete obsolete legacy-baseline scaffolding after confirming its coverage is duplicated by current binder/runtime tests, or replace any unique cases with direct assertions and then delete the scaffold.
Scope
_DiffCaseand map it to current direct tests, or promote missing cases into focused tests._run_legacy()and candidate-vs-legacy comparison scaffolding if no longer needed.Out of scope
Acceptance
Related