Skip to content

GFQL compat-executor reachability shrink - #1467

Merged
lmeyerov merged 1 commit into
masterfrom
fix/compat-reachability-1466
May 17, 2026
Merged

lmeyerov merged 1 commit into
masterfrom
fix/compat-reachability-1466

Conversation

@lmeyerov

@lmeyerov lmeyerov commented May 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes #1466.

  • audited _execute_compiled_query_compat_non_union() reachability after the native physical-dispatch lanes landed
  • planned projection-level WITH/RETURN DISTINCT through the logical route so the observed residual defer no longer needs a compat executor
  • removed the stale _execute_compiled_query_compat_non_union() wrapper and routed residual logical_plan is None feature-gap guards directly through the canonical chain executor
  • updated runtime cutover tests to assert physical planner route use without depending on the deleted private wrapper symbol

Validation

  • python3 -m pytest -q graphistry/tests/compute/gfql/test_logical_planner.py graphistry/tests/compute/gfql/cypher/test_lowering.py::test_compiled_query_sets_logical_plan_route_for_distinct_projection_shape graphistry/tests/compute/gfql/test_runtime_physical_cutover.py
  • python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.py graphistry/tests/compute/gfql/test_logical_planner.py graphistry/tests/compute/gfql/test_physical_planner.py -k 'not cudf'
  • ./bin/ruff.sh graphistry/compute/gfql/logical_planner.py graphistry/compute/gfql_unified.py graphistry/tests/compute/gfql/test_logical_planner.py graphistry/tests/compute/gfql/cypher/test_lowering.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.py
  • ./bin/typecheck.sh
  • git diff --check
  • DGX RAPIDS 25.02 GFQL/cuDF: 2377 passed, 22 skipped, 15 xfailed
  • DGX RAPIDS 26.02 GFQL/cuDF: 2377 passed, 22 skipped, 15 xfailed
  • review skill: converged after 2 clean waves; credentials gate clean
  • GitHub CI: green, including both tck-gfql runs

@lmeyerov
lmeyerov merged commit bccf9f4 into master May 17, 2026
137 checks passed
@lmeyerov
lmeyerov deleted the fix/compat-reachability-1466 branch May 17, 2026 01:45
@lmeyerov

Copy link
Copy Markdown
Contributor Author

#1472 follow-up merged via #1491.

  • Merge commit: adc2912c80d7284dc5aeb62acea1c8082fb629ce
  • Removed the obsolete M1 differential scaffold test file while preserving the one unique current-semantics case as direct lowering coverage.
  • Net LOC delta: -240 (+42 / -282).
  • This was a test-scaffold deletion only; no runtime/compiler behavior changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

D8 final GFQL compat-executor reachability audit and deletion/shrink decision

1 participant