Skip to content

D8 final GFQL compat-executor reachability audit and deletion/shrink decision #1466

Description

@lmeyerov

Summary

Final coordinator/implementation lane for #1419 after the known compat-executor blockers have landed:

The goal is to determine whether _execute_compiled_query_compat_non_union() and related compatibility wrappers/tests are still reachable, then either remove/shrink them or explicitly revise the #1419 2K LOC deletion target.

Goal

Get #1419 to a closeable state: either a real GFQL deletion PR with a fresh LOC receipt, or a recorded coordinator decision that the remaining safe deletion surface cannot meet the original >=2K LOC target.

Scope

Out of scope

Acceptance

Related

Activity

  1. lmeyerov commented on May 17, 2026

    @lmeyerov
    ContributorAuthor

    #1466 is closed by merged PR #1467:
    #1467

    Merge receipt:

    • Merge commit: bccf9f4789625854446811db8c57b15c1796999e
    • Final head commit: 9e64f337
    • Merged: 2026-05-16 PT

    Scope:

    • Audited _execute_compiled_query_compat_non_union() reachability after D1-D7 native route work.
    • Found the remaining generic compat executor surface had shrunk to a small stale dispatch shim.
    • Planned the observed residual projection-level WITH/RETURN DISTINCT shape natively via logical Distinct.
    • Deleted _execute_compiled_query_compat_non_union() and routed residual logical_plan is None feature-gap fallback directly through the canonical chain executor.

    Validation:

    • Targeted GFQL planner/runtime tests: 38 passed
    • Broad non-cuDF GFQL planner/runtime selection: 983 passed, 12 skipped, 112 deselected
    • ruff, typecheck, and git diff --check: green
    • DGX RAPIDS 25.02 full GFQL/cuDF: 2377 passed, 22 skipped, 15 xfailed
    • DGX RAPIDS 26.02 full GFQL/cuDF: 2377 passed, 22 skipped, 15 xfailed
    • PR CI green, including both tck-gfql runs
    • Review skill converged after 2 clean waves; credentials gate clean

    #1419 implication:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions