Repository navigation
fix(ci): unblock master lint lane (comment-guard finding above cap) - #1953
Merged
Merged
Conversation
Master's python-lint-types lane went red at 0c3f3a1: row_pipeline.py carried 7 issue-citing comments against a cap of 6 -- a baseline union, where two individually-green PRs landed citations neither snapshot saw. Restate the alias.alias contract by name instead of citing the issue; the pin test_unshadow_alias_marker_column_declines_when_there_is_nothing_to_restore already carries it. Cap unchanged at 6; --update-baseline also locks a never-recorded chain.py improvement (7 -> 6). No behavior change. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01AjbKuKheqDu78oapRT5AYm
lmeyerov
added a commit
that referenced
this pull request
Aug 19, 2026
…ar the master lint" The master-lint red is being fixed in #1953; reverting to avoid colliding with that fix. row_pipeline.py is now byte-identical to master again. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01AjbKuKheqDu78oapRT5AYm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master is red
python-lint-typesfails on master at0c3f3a1fa(run 32215582520). Because every test laneneeds:lint, all PR test lanes are skipping — CI is reporting no signal repo-wide, not green.Cause
Another baseline-union:
row_pipeline.pyreached 7 issue-citing comments against a cap of 6. Each contributing PR was green against its own snapshot; the union crossed the cap that neither could see.Fix
Restate the
alias.aliasunshadow contract by name rather than citing the issue number. The guard's premise holds here — the pintest_unshadow_alias_marker_column_declines_when_there_is_nothing_to_restorealready carries the issue in its name.No cap was raised.
--update-baselineadditionally locks a never-recorded improvement inchain.py(7 → 6), so this tightens the gate rather than relaxing it.Comment-only change to product code; no behavior change.
Verification
bin/ci_comment_density_guard.pyrun inside this worktree (it resolves SCAN_ROOT from__file__, so running it by path from elsewhere silently checks the wrong tree): rc=0bin/lint.shrc=0bin/typecheck.sh:Success: no issues found in 331 source files🤖 Generated with Claude Code
https://claude.ai/code/session_01AjbKuKheqDu78oapRT5AYm