Repository navigation
Conversation
Member
Author
|
CA2012 nowarn still exists for tests |
Member
|
I did not use AsTask so as to be sure that there was no allocation occurring. But whatever you think. |
Shane32
approved these changes
Oct 11, 2023
Member
|
Also note for SDLSorter that it is impossible to run asynchronously since it uses a static instance (cannot be derived) and the options class has no async members. (If I remember correctly.) |
Member
Author
Member
|
Excellent! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 89 89
Lines 4975 4975
Branches 494 494
=======================================
Hits 4788 4788
Misses 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

See notes in #332.