Skip to content

Use AsTask() - #349

Merged
sungam3r merged 1 commit into
masterfrom
as-task
Oct 11, 2023
Merged

sungam3r merged 1 commit into
masterfrom
as-task

Conversation

@sungam3r

Copy link
Copy Markdown
Member

See notes in #332.

@sungam3r
sungam3r requested a review from Shane32 October 11, 2023 06:39
@sungam3r sungam3r self-assigned this Oct 11, 2023
@sungam3r

Copy link
Copy Markdown
Member Author

CA2012 nowarn still exists for tests

@Shane32

Shane32 commented Oct 11, 2023

Copy link
Copy Markdown
Member

I did not use AsTask so as to be sure that there was no allocation occurring. But whatever you think.

@Shane32

Shane32 commented Oct 11, 2023

Copy link
Copy Markdown
Member

Also note for SDLSorter that it is impossible to run asynchronously since it uses a static instance (cannot be derived) and the options class has no async members. (If I remember correctly.)

@sungam3r

Copy link
Copy Markdown
Member Author

изображение

@sungam3r
sungam3r merged commit ab79ea8 into master Oct 11, 2023
@sungam3r
sungam3r deleted the as-task branch October 11, 2023 15:42
@Shane32

Shane32 commented Oct 11, 2023

Copy link
Copy Markdown
Member

Excellent!

Shane32 pushed a commit that referenced this pull request Oct 12, 2023
@codecov codecov Bot deleted a comment from codecov-commenter Apr 4, 2026
@codecov

codecov Bot commented Apr 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.24%. Comparing base (cdd6106) to head (ebd092a).
⚠️ Report is 55 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          89       89           
  Lines        4975     4975           
  Branches      494      494           
=======================================
  Hits         4788     4788           
  Misses        187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants