add-bound reports failure if build-depends are all conditional

hackage-cli add-bound cannot deal with the following structure, taken from https://hackage.haskell.org/package/regex-compat-tdfa-0.95.1.4/revision/0.cabal :

library
  if flag(newBase)
      Build-Depends:      base >= 4 && < 5, regex-base >= 0.93, regex-tdfa >= 1.1.0, array
  else
    if flag(splitBase)
      Build-Depends:      base >= 3.0, regex-base >= 0.93, regex-tdfa >= 1.1.0, array
    else
      Build-Depends:      base < 3.0,  regex-base >= 0.93, regex-tdfa >= 1.1.0

It reports for hackage-cli add-bound base '<4.15':

Edit failed, version ranges don't match:  <0 && <4.15 =/= <4.15

Looks like the default noVersion is wrong, it should be anyVersion (which is the unit of intersection):

hackage-cli/src/Main.hs

Lines 874 to 877 in da9c329

    
           extractRange :: LC.GenericPackageDescription -> C.PackageName -> C.VersionRange 
        
           extractRange gpd pkgName = case vss of 
        
               []     -> C.noVersion 
        
               (v:vs) -> List.foldl' C.intersectVersionRanges v vs

Fix #47 (`anyVersion` instead of `noVersion` as unit of intersection)

Navigation Menu

Repository navigation

`add-bound` reports failure if `build-depends` are all conditional #47

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	extractRange :: LC.GenericPackageDescription -> C.PackageName -> C.VersionRange
	extractRange gpd pkgName = case vss of
	[] -> C.noVersion
	(v:vs) -> List.foldl' C.intersectVersionRanges v vs

add-bound reports failure if build-depends are all conditional #47

Description

Activity

andreasabel commented on Jul 14, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`add-bound` reports failure if `build-depends` are all conditional #47