Skip to content
This repository was archived by the owner on Aug 3, 2024. It is now read-only.

Extract docs from strict/unpacked constructor args - #839

Merged
alexbiehl merged 1 commit into
haskell:ghc-headfrom
harpocrates:unpack-constructor-args
Jun 5, 2018
Merged

alexbiehl merged 1 commit into
haskell:ghc-headfrom
harpocrates:unpack-constructor-args

Conversation

@harpocrates

Copy link
Copy Markdown
Collaborator

This fixes #836 by matching the GHC changes in https://phabricator.haskell.org/D4727.

The GHC diff fixes the parse error around strictness annotations by moving the HsDocTy into the HsBangTy (if there is one). This patch correspondingly teaches Haddock to look into HsBangTy for docstrings.

@alexbiehl alexbiehl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alec!

@alexbiehl
alexbiehl merged commit 9a7f539 into haskell:ghc-head Jun 5, 2018
@alexbiehl

Copy link
Copy Markdown
Member

Sorry for my bad repo management lately, I have a new job and an constantly under fire.

sjakobi pushed a commit to sjakobi/haddock that referenced this pull request Jun 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants