Repository navigation
IORef based Socket is unsafe #335
Description
Activity
@winterland1989 Would you suggest text for doc on
close?Maybe something like this?
-- | Close the socket. Sending data to or receiving data from closed socket -- may lead to undefined behaviour. -- -- Note: this function is not thread-safe, it may not abort concurrently read or write -- operations, in fact other threads may continue to work on a fd reused by OS. -- close :: Socket -> IO () ...- added a commit that references this issue
on Jun 27, 2018 The document is written in '2.7' and 'master'.
Metadata
Metadata
Assignees
Labels
No labels
Peek through recently network's code, the new
IORef CIntbasedSocketseems to still have previous discussed fd-reuse race condiftion:Thread A acquires a
Socket's fd byfdSocket, when it's about to do some operations, the scheduler decide to pause thread A.Thread B close the socket, rewrite the
Socket'sIORef's content.Thread C open a new socket, unfortunately got the same fd number thread A is holding now.
When thread A is resumed, it's unaware of thread B and thread C 's behavior, thus the following operations will performed successfully, but on a wrong fd.
Maybe it's necessary to add some docs on
close?