Repository navigation
fdSocket should not be deprecated #418
Description
Activity
Relating to #398
@bitc I think your observation makes sense. I have no strong opinion. Please discuss this issue with guys above.
Sounds reasonable to me.
Should we follow the same pattern as
ForeinPtrhere? It provides the functionsunsafeForeignPtrToPtrandtouchForeignPtrfor this use case. We could similarly provideunsafeFdSocketandtouchSocket.@takano-akio If you provide a PR, it would be highly appreciated.
Ping @takano-akio
It's a fairly simple change. I can do it if you don't have time
@fumieval Welcome!
I'll do this today.
- added a commit that references this issue
on Aug 29, 2019 - added a commit that references this issue
on Sep 2, 2019
The docs for
fdSocketexplain why it can be dangerous, and the docs recommend usingwithFdSocketinstead.This is a great suggestion, but sometimes the structure of your code does not allow you to use a "with" style. (In my program, I need to pass the socket fd to some C code that will continue to write to it after my Haskell code block returns)
It is my understanding that it is possible to use
fdSocketsafely: you simply must make sure not toclosetheSocketwhile you are still using the fd. (And to make sure that you hang on to theSocketsomewhere so that the GC doesn't get it -- but you should be holding on to it anyway so that you cancloseit when you are finished with it)So I request that the
fdSocketfunction not be deprecated. I agree that the should have a warning, but the function should continue to be available and supported in future versions of this package.Thank you