Repository navigation
Conversation
Closed
Collaborator
|
I'm half and half on this PR. These aliases are documented as deprecated, but they have never received a proper deprecated pragma. I'd rather see their use removed and their definitions have a pragma attached in a minor release. We can then remove them definitively in a major release. |
Contributor
Author
|
@eborden Sure, I'll prepare something. |
Merged
Contributor
Author
|
I'll bring this PR in a pretty state soon. |
Collaborator
|
All good, just let me know when it is ready for review. |
Contributor
Author
This will require a version bump to 2.7
Contributor
Author
|
@eborden okay, I am all set. But there's no hurry, let the deprecations soak into the packages out there first. Anyway, I don't expect bad merge churn with these changes. |
Collaborator
|
@kazu-yamamoto Could be time to unearth this PR. |
Collaborator
|
@eborden OK. I will merge this with rebasing to make the history linear. |
Collaborator
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will require a version bump to 2.7