Repository navigation
comparing a return value of c_inet_addr with a positive number. - #261
Merged
Merged
Conversation
|
it's a bit sad this is raising a warning in this case (it's really not overflowing), but I would suggest fixing the warning not by hardcoding The later |
kazu-yamamoto
force-pushed
the
inet_addr
branch
from
December 12, 2017 00:40
e7c1685 to
e2736f9
Compare
kazu-yamamoto
force-pushed
the
inet_addr
branch
from
December 12, 2017 00:49
e2736f9 to
dcd08cc
Compare
Collaborator
Author
|
@vincenthz Thank you for your suggestion. I took @eborden Than you for your review. I have modified, rebased and merged the commit. I'm now trying to make history linear. So, I did |
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Jan 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c_inet_addrreturns a value ofWord32.So, we cannot compare it with (-1).
GHC 8.2 detects this bug.