Repository navigation
Conversation
Collaborator
Author
|
@eborden You can confirm this by this script: You should insert |
eborden
approved these changes
Dec 15, 2017
eborden
left a comment
Collaborator
There was a problem hiding this comment.
This looks good from a glance. I'd like to spend a bit more time exploring this tomorrow.
kazu-yamamoto
force-pushed
the
gc-socket
branch
from
December 15, 2017 13:31
fcb8d45 to
d7e98e9
Compare
Collaborator
|
LGTM |
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Jan 29, 2018
* closing socket when it becames unreachable for GC. * GHC 7.4 does not provide mkWeakMVar.
Closed
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
Socketbecomes unreachable but is not explicitly closed byclose, GC should collect it.This fixes #4 and #236.