Repository navigation
Fix finalizer getting triggered in ghc 8.2.2 - #288
Merged
Merged
Conversation
GHC 8.2.2 more aggresively reclaims `Weak`. This causes the socket to be closed in `accept` before `c_accept` is called. Utilizing `withMVar` allows the reference to be held until `c_accept` has been called.
kazu-yamamoto
approved these changes
Dec 29, 2017
kazu-yamamoto
left a comment
kazu-yamamoto
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Please merge this into 2.7 by yourself.
If you want to merge this to master, please go ahead. But please note that the code changed a lot.
eborden
added a commit
that referenced
this pull request
Dec 30, 2017
GHC 8.2.2 more aggressively reclaims `Weak`. This causes the socket to be closed in `accept` before `c_accept` is called. Utilizing `withMVar` allows the reference to be held until `c_accept` has been called.
Collaborator
Author
|
I also merged this in to |
Closed
kazu-yamamoto
pushed a commit
to kazu-yamamoto/network
that referenced
this pull request
Jan 29, 2018
* Fix finalizer getting triggered in ghc 8.2.2 GHC 8.2.2 more aggresively reclaims `Weak`. This causes the socket to be closed in `accept` before `c_accept` is called. Utilizing `withMVar` allows the reference to be held until `c_accept` has been called. * Update variable for readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHC 8.2.2 more aggresively reclaims
Weak. This causes the socket to beclosed in
acceptbeforec_acceptis called. UtilizingwithMVarallows the reference to be held until
c_accepthas been called.This fixes: #287