Skip to content

GCing Socket in the new definition. - #301

Closed
kazu-yamamoto wants to merge 1 commit into
haskell:masterfrom
kazu-yamamoto:gc-socket
Closed

GCing Socket in the new definition.#301
kazu-yamamoto wants to merge 1 commit into
haskell:masterfrom
kazu-yamamoto:gc-socket

Conversation

@kazu-yamamoto

@kazu-yamamoto kazu-yamamoto commented Jan 29, 2018

Copy link
Copy Markdown
Collaborator

This should fix #299.

Testing:

  • Remove the comment around the finalizer
  • Run tests/GCSocket.hs

@kazu-yamamoto
kazu-yamamoto requested a review from eborden January 29, 2018 07:32
@kazu-yamamoto

kazu-yamamoto commented Jan 29, 2018

Copy link
Copy Markdown
Collaborator Author

GHC 7.10 results in:

  tests/SimpleSpec.hs:56: 
  1) Simple.sendMany works well
       uncaught exception: IOException of type InvalidArgument (threadWait: invalid argument (Bad file descriptor))

@kazu-yamamoto kazu-yamamoto mentioned this pull request Jan 30, 2018
Closed
3 tasks done
@kazu-yamamoto

kazu-yamamoto commented Jan 31, 2018

Copy link
Copy Markdown
Collaborator Author

Closing this due to #302.

@kazu-yamamoto
kazu-yamamoto deleted the gc-socket branch February 6, 2018 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eborden eborden Awaiting requested review from eborden

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Utilize Weak for finalizing socket on GC in 3.0.0.0

1 participant

@kazu-yamamoto