Repository navigation
0.12.1.1 breaking change w.r.t. 0.12.0.3 #287
Description
Activity
- added a commit that references this issue
on Feb 1, 2020 Not sure what was the motivation behind this change, but the proper way to fix this issue I see is bring back
mkTypeas deprecated:mkType :: String -> DataType {-# INLINE mkType #-} {-# DEPRECATED mkType "In favor of mkVectType" #-} mkType = mkNoRepType
and make new release
vector-0.12.1.2, while deprecatingvector-0.12.1.0andvector-0.12.1.1@cartazio Would you be keen to making such release if I fix it in proposed way?
- Absolutely I did have an “oh no moment” late last night when I remembered that the data instance had existed but was so useless that I was used to treating it as not existing. So indeed I can do that post haste. Email / msg me or holler on a ticket when you think it’s in a good shape. Or I can do a thing. Was pointed out to me that currently we don’t have terribly good test coverage atm wrt hpc coverage metrics (granted we couldn’t even run the optimized test suite till last week :) @hvr @davean is https://hackage.haskell.org/package/hackage-diff The tool you two have used for doing api diffs? Or was it a different one? Probably would be good to add to release engineering workflow / checklist (which we don’t have quite yet ;))…On Sat, Feb 1, 2020 at 1:03 PM Alexey Kuleshevich ***@***.***> wrote: Not sure what was the motivation behind this change, but the proper way to fix this issue I see is bring back mkType as deprecated: mkType :: String -> DataType {-# INLINE mkType #-} {-# DEPRECATED mkType "In favor of mkVectType" #-} mkType = mkNoRepType and make new release vector-0.12.1.3, while deprecating vector-0.12.1.1 and vector-0.12.1.2 @cartazio <https://github.com/cartazio> Would you be keen to making such release if I fix it in proposed way? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#287?email_source=notifications&email_token=AAABBQQZABUCLHPHFQZBBFTRAW2QZA5CNFSM4KOUPBK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKRC6RA#issuecomment-581054276>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAABBQSRXFPNDHGMQHTBP4LRAW2QZANCNFSM4KOUPBKQ> .
- added a commit that references this issue
on Feb 1, 2020 The fix is ready: #288
The tool you two have used for doing api diffs?
There was recently an announcement of policemen that could potentially help with that. Have not used it though, so can't vouch for it.
https://www.reddit.com/r/haskell/comments/ew1vd5/blog_post_policeman_new_way_to_assign_pvp/PVP should have been fixed long time ago: haskell/pvp/issues/12
But thats fine, I'll make a fix without
DEPRECATEpragma.- added a commit that references this issue
on Feb 1, 2020 Unfortunately for now, we must adhere
Must we?
Reacted by Alexey KuleshevichFIXED
- added a commit that references this issue
on Apr 11, 2020 - added a commit that references this issue
on Jun 5, 2020
It looks as if
vector-0.12.1.1has renamed theVector.Generic.mkTypefunction toVector.Generic.mkVecType.cf.
mkType@ 0.12.0.3 versusmkVecType@ 0.12.1.1