Repository navigation
Separate streams into a separate package #355
Description
Activity
Sounds good.
- +1, have wanted this before…On Sat, Jan 16, 2021, 14:37 Bodigrim ***@***.***> wrote: Sounds good. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#355 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEOIX24Z2U5PE7NE4Y6CQKTS2H2IDANCNFSM4WFQTUQQ> .
+1
Another benefit of splitting it into its own package would force us to write some tests and maybe even benchmarks for the stream functionality itself.
We'll also have to review document and possible clean up public API of package instead of treating it as implementation detail of vector.
What is place of Bundle in this? Should it go into new package or remain part of vector proper?
I am pleasantly surprise to see everyone supporting this!
What is place of Bundle in this?
Bundle will have to stay inside of
vector, becauseBundledepends onVectorclass:data Chunk v a = Chunk Int (forall m. (PrimMonad m, Vector v a) => Mutable v (PrimState m) a -> m ())
But that's ok, because I don't think there is any desire to make Bundle work with anything else other than vector.
Now that I have your guy's support I'll start working on this, but only after I am done with vector-0.12.2.0 release (which is pretty close, I got quite heads way with backporting functionality last night).
I would really like to see this split before release of vector-0.13.0.0. A bit of bikeshedding: name for new package? Things that come to mind:
vector-streamstream-fusion- ...
Do you plan to make it part of 0.13 release? If so I'll it to list (compiling it right now)
Wrt name is have slight preference for
vector-streambut don't acre much about it.Reacted by Alexey KuleshevichYou do. Sorry, missed that
+1 to
vector-streamReacted by Alexey KuleshevichJust a random idea, which may be horrible, but how feasible would it be as a long term goal for
textandvectorto share this streaming framework?I think it's doable although stream types are subtly different.
text's one is strict in both elements and state, andvector's is lazy. Whether it's something that should be done is another question entirely. And much more difficult to answer
This is a long shot, but I thought I'd ask anyways.
Data.Vector.Fusion.Stream.Monadicis a quite useful module and I know of at least two packages that could use it without depending on vector, namelymassivandstreamly. There are a few others I found, but they are less maintained.Another benefit of splitting it into its own package would force us to write some tests and maybe even benchmarks for the stream functionality itself.
Thoughts?