Skip to content
This repository was archived by the owner on Sep 3, 2024. It is now read-only.

Stick state argument to request and unify types across the handlers. - #3

Merged
hyperthunk merged 3 commits into
haskell-distributed:masterfrom
dpwiz:master
Feb 21, 2017
Merged

hyperthunk merged 3 commits into
haskell-distributed:masterfrom
dpwiz:master

Conversation

@dpwiz

@dpwiz dpwiz commented Mar 8, 2016

Copy link
Copy Markdown
Contributor

First changeset is breaking, while the latter is optional and could be seen as an example.

@hyperthunk

Copy link
Copy Markdown
Member

This looks good to me. I'm going to fix CI for this project and its dependencies (we're broken on -extras, and therefore this library too) by moving travis to use stack for the build, then I'll merge this. Probably we're looking around 48 hours.

@dpwiz

dpwiz commented Mar 8, 2016

Copy link
Copy Markdown
Contributor Author

Wow, such a simple change made quite a few ripples. Everything makes much more sense now.
Qi flow restored 😄

@hyperthunk

Copy link
Copy Markdown
Member

Ha! Just wait until I've merged this and all the downstreams break. :D

I want to fix the CI build for this library before I merge this, which I'll try to do this afternoon.

@hyperthunk

Copy link
Copy Markdown
Member

We are waiting on haskell-distributed/distributed-process-extras#11 and haskell-distributed/distributed-process-async#6, plus the release to hackage, then I'll need to fix the CI build for this project (and switch to a stack build), then we can merge this.

@hyperthunk

Copy link
Copy Markdown
Member

I'm about to release a new -extras and we should be incorporating this shortly.

@hyperthunk
hyperthunk merged commit c6ee2b3 into haskell-distributed:master Feb 21, 2017
hyperthunk added a commit that referenced this pull request Feb 21, 2017
This is an API breaking change and will require a version increment.
Closes #3.
Thanks Alexander Bondarenko.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants