Repository navigation
Add testing to GlobWindowsPaths - #2
Merged
iamazeem merged 3 commits intoFeb 21, 2025
Conversation
iamazeem
reviewed
Feb 14, 2025
jtmcg
force-pushed
the
jtmcg/add-testing-to-globbing
branch
from
February 21, 2025 17:30
29b35eb to
90b4e9a
Compare
Author
|
Alright, I've backed out of the change. Let's merge this into your PR branch so that we can continue the discussion there 🙂 |
iamazeem
merged commit Feb 21, 2025
8748bb0
into
iamazeem:5099-gh-release-create-upload-expand-glob-patterns-on-windows
iamazeem
pushed a commit
that referenced
this pull request
Jul 11, 2026
The documented dnf install lines pin resolution to the gh-cli repo with --repo gh-cli. That repo only ships the gh package, so on a fresh Fedora install without git already present the install fails with "nothing provides git needed by gh-2.87.3-1.x86_64 from gh-cli" (cli#12808). Dropping --repo lets dnf pull git from the system repos while still installing gh from gh-cli. The maintainer suggested this in the issue thread after spotting that other projects (docker, vagrant) use addrepo without the restrictive --repo flag. Closes cli#12808 Signed-off-by: Charlie Tonneslan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my tests example. Note, I'm not actually testing that
filepath.Glob()is doing what its supposed to be doing - I'm checking the function's interfaces of patterns in and matches out. These tests actually show that the make comment doesn't actually work, too, which is a bonus.