Repository navigation
Fix dialog InvalidOperationException - #434
Merged
ikkentim merged 1 commit intoOct 15, 2023
Merged
Conversation
Owner
It might be a good idea to try this out. To try that, edit the |
duydang2311
force-pushed
the
433-fix-dialog-task-exception
branch
from
October 15, 2023 12:26
3d93214 to
cba02a9
Compare
Contributor
Author
|
I also think it's better to do that. |
Owner
|
Thank you! |
LDami
pushed a commit
to LDami/SampSharp
that referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should close #433. I have changed the response handler from
SetResulttoTrySetResultto make it safe from the task already completed exception.However, a better fix might be to not let the response handler executes the second time by destroying the
VisibleDialogcomponent when the player responds or disconnects. There are two related callbacks:OnPlayerDisconnectandOnPlayerDialogResponse. But I'm not sure about the execution order of these two callbacks.