Repository navigation
[SYCL] Possibly redundant getSpirvSource() call in program_manager.cpp #26
Description
Fairly irrelevant issue and I could be wrong and misunderstanding the code (I apologize if I am) but I think the new addition of the function createOpenCLProgram inside sycl/source/detail/program_manager/program_manager.cpp makes the call to getSpirvSource() on line 125 inside the function getBuiltOpenCLProgram redundant.
As createOpenCLProgram calls it on line 115 (which is invoked by getBuiltOpenCLProgram) and the return from the invocation on line 125 doesn't appear to be used at the moment. The check for existing Spirv source inside getSpirvSource()probably stops the source getting loaded in twice but thought I'd bring it up in case.
Metadata
Metadata
Assignees
Labels
No labels
Activity
bader commentedon Feb 13, 2019
@agozillon, thanks for reporting this!
I talked to @vladimirlaz and it seems to be an artifact of merge conflict resolution.
vladimirlaz commentedon Feb 15, 2019
The fix has been merged.
Remove a useless assertion in clang-check.
Revert rL357915 from cfe/trunk: Remove a useless assertion in clang-c…
Remove a useless assertion in clang-check.
Merge from 'master' to 'sycl-web' (intel#26)
Revert "[Concepts] Placeholder constraints and abbreviated templates"
Merge from 'master' to 'sycl-web' (intel#26)
[clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch
[lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across …
Revert "[Coro] [async] Disable inlining in async coroutine splitting …
[tsan] Fix running check-ubsan with COMPILER_RT_DEBUG=ON
Revert "[mlir][loops] Reland Refactor LoopFuseSiblingOp and support p…
Fix for codegen Crash in Clang when using locator omp_all_memory with…
Revert "[Clang][analyzer] replace Stmt* with ConstCFGElementRef in Sy…
[Driver] Reject -mcmodel=tiny on X86 (#125643)
[clang][bytecode] Classify variable initializer, not the decl (#146338)
Revert "[clang][bytecode] Check if block is initialized before invoki…
[LifetimeSafety] Read lifetimebound attribute on implicit 'this' from…
[LAA] Fix type mismatch in getStartAndEndForAccess. (#183116)
[lldb] Fix stale Symbol pointer crash in statusline after 'target sym…
[MLIR][XeVM] Fix mask lifetime in HandleVectorExtractPattern (#223879)