Repository navigation
[SYCL] Enable use of variadic templates in SYCL kernel names. - #103
Conversation
|
@agozillon, does this patch covers #46? |
d5cf909 to
9dbb7d3
Compare
Test cases from that patch are successfully passed with this patch. |
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
@agozillon, does this patch covers #46?
Test cases from that patch are successfully passed with this patch.
Great! @agozillon are you okay if we commit this version instead of #46?
|
Those tests are outdated, I updated it. They're here. If it is necessary I can add it. |
Do they cover more code than test case in your patch? |
|
I guess, yes. |
|
LGTM, better fix than my own, even adds to upstream Clang, I have no problems using this over my own pull request. If you add the tests I added that'd be nice, but if you don't then that's not a problem either. |
Added support for template parameters pack processing to the clang::TypeName::getFullyQualifiedTemplateArgument method. Signed-off-by: Alexey Voronov <[email protected]>
9dbb7d3 to
56ed8f3
Compare
Thank you. I will apply your test cases with a little changes. |
CONFLICT (content): Merge conflict in clang/test/CodeGen/annotations-field.c CONFLICT (content): Merge conflict in clang/lib/CodeGen/CodeGenFunction.cpp
5 participants
Added support for template parameters pack processing to the
clang::TypeName::getFullyQualifiedTemplateArgument method.
Signed-off-by: Alexey Voronov [email protected]