Skip to content

Try to get QT To work on windows. - #9702

Closed
Carreau wants to merge 1 commit into
ipython:masterfrom
Carreau:qt-windows
Closed

Carreau wants to merge 1 commit into
ipython:masterfrom
Carreau:qt-windows

Conversation

@Carreau

@Carreau Carreau commented Jul 6, 2016

Copy link
Copy Markdown
Member

@jorisvandenbossche can you try that ?

I honestly have close to no clue what I am doing, as eventloop and threading is far from where I am comfortable.

I guess the other alternative would be to mimic the other inputhook are doing on the IPykernel side and timeshare. I'll see if I can borrow a windows box tomorrow from one of my officemates.

I'm also unsure if I can use things like msvcrt.kbhit() with prompt_toolkit.

CC @fperez , @minrk @takluyver .

@Carreau Carreau added this to the 5.0 milestone Jul 6, 2016
@fperez

fperez commented Jul 6, 2016

Copy link
Copy Markdown
Member

I haven't worked with this code recently and I don't know why we have a regression, but as a general rule, threads at the heart of our event loop system have been historically nothing but a source of pain. A long time ago, we were able to move away from threads (the original solution for GUI integration dating back to ~2003/4), and that was a huge gain in stability.

We should really think long and hard about how to figure out a non-thread solution.

For reference, this is an attempt to fix #9652.

@Carreau

Carreau commented Jul 6, 2016

Copy link
Copy Markdown
Member Author

Agreed I would prefer to not use thread, but it was suggested so I tried.

Something like that would be the alternative I guess.

@fperez

fperez commented Jul 6, 2016

Copy link
Copy Markdown
Member

That sounds a bit more palatable than a threads solution (plus, it's what we've used for years, so it has the benefit of being battle-tested).

@Carreau

Carreau commented Jul 6, 2016

Copy link
Copy Markdown
Member Author

That sounds a bit more palatable than a threads solution (plus, it's what we've used for years, so it has the benefit of being battle-tested).

I'll try.

@minrk

minrk commented Jul 6, 2016

Copy link
Copy Markdown
Member

I like #9702 a lot more, and it's working for me. We've had headaches with eventloops in threads for years, from the old -wthread days, so I'm happy that we have a solution that doesn't require reintroducing a thread for this.

@minrk minrk closed this in #9706 Jul 6, 2016
@minrk minrk modified the milestones: no action, 5.0 Jul 6, 2016
@Carreau
Carreau deleted the qt-windows branch January 14, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants