Skip to content

Try to fix QT event loop take II - #9705

Closed
Carreau wants to merge 1 commit into
ipython:masterfrom
Carreau:qt-loop-2
Closed

Try to fix QT event loop take II#9705
Carreau wants to merge 1 commit into
ipython:masterfrom
Carreau:qt-loop-2

Conversation

@Carreau

@Carreau Carreau commented Jul 6, 2016

Copy link
Copy Markdown
Member

Second try at fixing #9652

@jorisvandenbossche can you try that as well ? It's late so it's not a clean implementation. In particular you likely cannot deactivate the eventloop.

CC @fperez , @minrk

@takluyver, should we try to merge the lib/inputhook and the pt_inputhook together ? It looks like the former could sometime just take an (optional) context argument.

@Carreau Carreau modified the milestone: 5.0 Jul 6, 2016
@minrk

minrk commented Jul 6, 2016

Copy link
Copy Markdown
Member

Thanks, @Carreau! I've tested this and it's working on my Windows VM.

@minrk minrk mentioned this pull request Jul 6, 2016
Closed
@jorisvandenbossche

jorisvandenbossche commented Jul 6, 2016

Copy link
Copy Markdown
Contributor

Yes, I can confirm it is working for me as well. Thanks a lot!

@minrk

minrk commented Jul 6, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Isn't lib/inputhook pretty much deprecated, now that we have the pt_inputhooks?

I'm okay with merging this as-is for 5.0, and then targeting a proper merge of pt_inputhooks and lib/inputhook for 5.1.

I've also confirmed that the behavior with this one is still fine on OS X.

@takluyver

takluyver commented Jul 6, 2016

Copy link
Copy Markdown
Member

Yes, lib/inputhook is deprecated. I'm going to try to make a variant of this which doesn't involve lib/inputhook.

@takluyver

takluyver commented Jul 6, 2016

Copy link
Copy Markdown
Member

#9706 is my try

@takluyver takluyver mentioned this pull request Jul 6, 2016
Merged
@minrk minrk closed this in #9706 Jul 6, 2016
@minrk minrk modified the milestones: no action, 5.0 Jul 6, 2016
@Carreau

Carreau commented Jul 6, 2016

Copy link
Copy Markdown
Member Author

If they are deprecated we should raise deprecation warnings.
On Jul 6, 2016 05:04, "Min RK" [email protected] wrote:

Closed #9705 #9705 via #9706
#9706.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9705 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAUez5oQJ4gejqPqOuyUB7JvlHKv89Xrks5qS5nIgaJpZM4JFuZ6
.

@Carreau
Carreau deleted the qt-loop-2 branch January 14, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

no action

Development

Successfully merging this pull request may close these issues.

4 participants

@Carreau @minrk @jorisvandenbossche @takluyver