Skip to content

Esm fixes - #34

Merged
joshuanianji merged 5 commits into
mainfrom
esm-fixes
Mar 15, 2023
Merged

joshuanianji merged 5 commits into
mainfrom
esm-fixes

Conversation

@joshuanianji

@joshuanianji joshuanianji commented Mar 15, 2023 •

Copy link
Copy Markdown
Owner

Ci workflow for 9212dfb failed to run because ESM does not work with namespaced directories like date-fns.

I changed the run command to use the --es-module-specifier-resolution=node flag, which will hopefully get things working.

Maybe this will help my esm imports?

Notes:
- SO Discussion: https://stackoverflow.com/a/65588027
- GH Discussion: nodejs/node#27408 (comment)
those were only for arm, and i only installed them to test stuff on my own machine
@joshuanianji
joshuanianji merged commit dd72559 into main Mar 15, 2023
@joshuanianji
joshuanianji deleted the esm-fixes branch March 15, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant