Release: use correct build date in release verification by timmywil · Pull Request #5521 · jquery/jquery

timmywil · 2024-07-17T21:20:43Z

Summary

the date is actually the date of the commit prior to the tag commit, as the files are built and then committed.
also, the CDN should still be checked for non-stable releases, and should use different filenames (including in the map files).
certain files should be skipped when checking the CDN.
removed file diffing because it ended up being far too noisy, making it difficult to find the info I needed.
because the build script required an addition, release verification will not work until the next release.

Checklist

New tests have been added to show the fix or feature works
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

mgol

One suggestion. LGTM overall, though.

timmywil · 2024-07-18T00:59:47Z

+		}
+		console.log();
+		for ( const file of mismatchingFiles ) {
+			console.log( `❌ ${ file }` );


These characters do seem to print fine in GH actions.

Sample: https://github.com/timmywil/jquery/actions/runs/9983672787/job/27591642443

As expected, the files with a date fail, but the min and map files pass.

timmywil · 2024-07-18T01:00:12Z

I was debugging the workflow a bit on my fork and made a couple tweaks:

fixed an issue with the build in GH actions where setting the env option in the exec() was overriding the PATH variable. This seemed to only affect Linux.
if the build is not reproducible, print all files and whether each matched. See my other comment for a sample.
called the node script directly from release-it to avoid the npm script log in GH release notes (which I manually removed this time)
excluded changelog.md from release:clean, which is now committed
separated the post release script from release-it for now. This is so we can keep manual verification before each push. The exact post-release command is printed at the end of the release for convenience.

mgol

Minor remarks to address, otherwise LGTM

- the date is actually the date of the commit *prior* to the tag commit, as the files are built and then committed. - also, the CDN should still be checked for non-stable releases, and should use different filenames (including in the map files). - certain files should be skipped when checking the CDN. - removed file diffing because it ended up being far too noisy, making it difficult to find the info I needed. - because the build script required an addition, release verification will not work until the next release. - print all files in failure case and whether each matched - avoid npm script log in GH release notes changelog - exclude changelog.md from release:clean command - separate the post-release script from release-it for now, so we can keep manual verification before each push. The exact command is printed at the ened for convenience. Close jquerygh-5521

Ref jquerygh-5521

- the date is actually the date of the commit *prior* to the tag commit, as the files are built and then committed. - also, the CDN should still be checked for non-stable releases, and should use different filenames (including in the map files). - certain files should be skipped when checking the CDN. - removed file diffing because it ended up being far too noisy, making it difficult to find the info I needed. - because the build script required an addition, release verification will not work until the next release. - print all files in failure case and whether each matched - avoid npm script log in GH release notes changelog - exclude changelog.md from release:clean command - separate the post-release script from release-it for now, so we can keep manual verification before each push. The exact command is printed at the ened for convenience. Closes jquerygh-5521

Ref jquerygh-5521

mgol

Looks mostly good, I have some minor comments. Nice work!

- the date is actually the date of the commit *prior* to the tag commit, as the files are built and then committed. - also, the CDN should still be checked for non-stable releases, and should use different filenames (including in the map files). - certain files should be skipped when checking the CDN. - removed file diffing because it ended up being far too noisy, making it difficult to find the info I needed. - because the build script required an addition, release verification will not work until the next release. - print all files in failure case and whether each matched - avoid npm script log in GH release notes changelog - exclude changelog.md from release:clean command - separate the post-release script from release-it for now, so we can keep manual verification before each push. The exact command is printed at the ened for convenience. Closes jquerygh-5521

Ref jquerygh-5521

- the date is actually the date of the commit *prior* to the tag commit, as the files are built and then committed. - also, the CDN should still be checked for non-stable releases, and should use different filenames (including in the map files). - certain files should be skipped when checking the CDN. - removed file diffing because it ended up being far too noisy, making it difficult to find the info I needed. - because the build script required an addition, release verification will not work until the next release. - print all files in failure case and whether each matched - avoid npm script log in GH release notes changelog - exclude changelog.md from release:clean command - separate the post-release script from release-it for now, so we can keep manual verification before each push. The exact command is printed at the ened for convenience. Closes gh-5521

Ref gh-5521

timmywil added the Release label Jul 17, 2024

timmywil added this to the 4.0.0 milestone Jul 17, 2024

timmywil requested a review from mgol July 17, 2024 21:20

timmywil commented Jul 17, 2024

View reviewed changes

Comment thread .gitignore

timmywil commented Jul 17, 2024

View reviewed changes

Comment thread .release-it.cjs

mgol approved these changes Jul 17, 2024

View reviewed changes

Comment thread build/release/verify.js Outdated

timmywil force-pushed the release branch 5 times, most recently from 20af991 to 0590747 Compare July 18, 2024 00:56

timmywil commented Jul 18, 2024

View reviewed changes

timmywil mentioned this pull request Jul 18, 2024

Release: migrate release process to release-it (3.x) #5522

Merged

2 tasks done

timmywil requested a review from mgol July 18, 2024 18:48

mgol approved these changes Jul 19, 2024

View reviewed changes

Comment thread .release-it.cjs

Comment thread build/release/verify.js Outdated

timmywil force-pushed the release branch from d849b14 to 38b480b Compare July 23, 2024 15:43

timmywil added a commit to timmywil/jquery that referenced this pull request Jul 23, 2024

Build: use --input-type=module in npm scripts

f1b54d9

Ref jquerygh-5521

timmywil force-pushed the release branch from 38b480b to f1b54d9 Compare July 23, 2024 15:46

timmywil added a commit to timmywil/jquery that referenced this pull request Jul 24, 2024

Build: use --input-type=module in npm scripts

0fdd312

Ref jquerygh-5521

timmywil force-pushed the release branch from 658f805 to 9b855e6 Compare July 24, 2024 13:26

timmywil requested a review from mgol July 24, 2024 15:27

mgol approved these changes Jul 26, 2024

View reviewed changes

Comment thread .husky/commit-msg

Comment thread build/release/verify.js Outdated

timmywil added 3 commits July 29, 2024 12:23

Build: use --input-type=module in npm scripts

9de8773

Ref jquerygh-5521

Build: upgrade dependencies, including requirejs to 2.3.7

707a15c

timmywil force-pushed the release branch from 48263a1 to 707a15c Compare July 29, 2024 16:30

timmywil merged commit a7d3383 into jquery:main Jul 29, 2024

timmywil added a commit that referenced this pull request Jul 29, 2024

Build: use --input-type=module in npm scripts

57ef12e

Ref gh-5521

timmywil deleted the release branch July 29, 2024 16:34

github-actions Bot locked as resolved and limited conversation to collaborators Sep 24, 2025

Navigation Menu

Repository navigation

Release: use correct build date in release verification - #5521

Release: use correct build date in release verification#5521
timmywil merged 3 commits into
jquery:mainfrom
timmywil:release

timmywil commented Jul 17, 2024

Uh oh!

Uh oh!

Uh oh!

mgol left a comment

Uh oh!

Uh oh!

timmywil Jul 18, 2024 •

edited

Loading

Uh oh!

timmywil commented Jul 18, 2024 •

edited

Loading

Uh oh!

mgol left a comment

Uh oh!

Uh oh!

Uh oh!

mgol left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

timmywil commented Jul 17, 2024

Summary

Checklist

Uh oh!

Uh oh!

Uh oh!

mgol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

timmywil Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timmywil commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mgol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mgol left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

timmywil Jul 18, 2024 •

edited

Loading

timmywil commented Jul 18, 2024 •

edited

Loading

mgol left a comment •

edited

Loading