Repository navigation
Tests: Run tests in Edge in IE mode in GitHub Actions - #5540
Merged
Merged
Conversation
Member
Author
|
Interesting that the |
mgol
changed the title
mgol
added
the
Discuss in Meeting
While Edge in IE mode is not guaranteed to match IE 11 in every aspect, in practice it generally does. Testing in this mode in GitHub Actions will allow us to catch most IE-breaking issues at the PR level. This change also adds missing npm scripts: `test:chrome`, `test:edge` & `test:ie`.
timmywil
approved these changes
Sep 9, 2024
timmywil
removed
the
Discuss in Meeting
mgol
added a commit
that referenced
this pull request
Sep 9, 2024
While Edge in IE mode is not guaranteed to match IE 11 in every aspect, in practice it generally does. Testing in this mode in GitHub Actions will allow us to catch most IE-breaking issues at the PR level. This change also adds missing npm scripts: `test:chrome`, `test:edge` & `test:ie`. Closes gh-5540 (cherry picked from commit 6d78c07)
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While Edge in IE mode is not guaranteed to match IE 11 in every aspect, in practice it generally does. Testing in this mode in GitHub Actions will allow us to catch most IE-breaking issues at the PR level.
This change also adds missing npm scripts:
test:chrome,test:edge&test:ie.I tested it on a Windows 11 for ARM VM on macOS and in GitHub Actions on my fork - example run: https://github.com/mgol/jquery/actions/runs/10533747178/job/29190235999?pr=15
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com