This repository was archived by the owner on Jan 13, 2024. It is now read-only.
Repository navigation
fix for issue X64 pointer arithmetic issue #18 - #19
Merged
Merged
Conversation
kbilsted
reviewed
Nov 8, 2016
kbilsted
left a comment
kbilsted
left a comment
Owner
There was a problem hiding this comment.
How does this work when compiling on x32?
Contributor
Author
|
For x32 there will be no visible change. int64 is big enough to contain all the 32 bit range and intptr is just 32bit in this case so this cast is reducing the value range again, see also links in #18 for further explaination. |
TaoK
added a commit
to TaoK/PoorMansTSqlFormatter
that referenced
this pull request
Dec 27, 2016
- Change DllExport library from unversioned inclusion to NuGet package (possible further update required, there is another more recent NuGet package available called DllExport apparently?) - Patch NPP Plugin helper to support x64 (kbilsted/NotepadPlusPlusPluginPack.Net#19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #18