Repository navigation
Fix a crash when resizing to a non-finite size - #888
Merged
kean merged 1 commit intoAug 15, 2026
Merged
Conversation
`Int(_:)` traps on a `CGFloat` that is NaN, infinite, or out of range, so a target size coming from the user crashed the processing queue instead of failing gracefully.
kean
force-pushed
the
fix/resize-non-finite-size-crash
branch
from
August 15, 2026 14:51
d156b7f to
1affc80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CGContext.makeconverted the target size withInt(_:), which traps on aCGFloatthat is NaN, infinite, or out of theIntrange, soImageProcessors.Resize(size: CGSize(width: .nan, height: .nan))crashed the processing queue.The dimensions are now validated before the conversion and the context creation returns
nil, which the processors already treat as a failure. The resizing paths also reject non-finite target sizes up front so that cropping and non-cropping behave the same way instead of silently returning the original image.Based on #886, which touches the same function. Merge that one first; the base will retarget to
mainautomatically.