Repository navigation
Fix progressive previews being dropped after a failed cached-data decode - #894
Merged
Merged
Conversation
`decodeCachedData` goes through `AsyncPipelineTask.decode`, which stores the decoding-queue handle in `operation` whenever the decoder is asynchronous. `didFinishDecoding(with:)` never reset it, unlike `TaskFetchOriginalImage.didFinishDecoding`. When the cached decode failed and the task fell back to `fetchImage()`, the stale handle tripped the progressive back-pressure guards, so every preview was silently dropped for the rest of the task's lifetime.
kean
added a commit
that referenced
this pull request
Aug 15, 2026
Fix progressive previews being dropped after a failed cached-data decode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskLoadImage.decodeCachedDatagoes throughAsyncPipelineTask.decode, which stores the decoding-queue handle inoperationwhenever the decoder is asynchronous — any custom decoder, since the protocol default forisAsynchronousistrue, or the default decoder with thumbnail options.didFinishDecoding(with:)never reset it, unlikeTaskFetchOriginalImage.didFinishDecoding.When the cached decode fails and the task falls back to
fetchImage(), the stale non-nil handle trips the progressive back-pressure guards (else if operation != nil { return }), so every progressive preview is silently dropped for the rest of the task's lifetime. The final image still arrives.didFinishDecoding(with:)now clearsoperationfirst.