Repository navigation
fixes for test_wcs - #1
Merged
Merged
Conversation
kelle
self-requested a review
January 9, 2017 19:59
Owner
|
Ok, so Also, I really appreciate the comments you added in |
Author
|
Sheer trial and error, I fear. Indeed, both work fine under python3, but |
kelle
pushed a commit
that referenced
this pull request
May 11, 2017
Remove unit checks that are irrelevant for the bug fix.
kelle
pushed a commit
that referenced
this pull request
May 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kelle - for
test_wcsthe problem also seemed to be that one cannot useget_pkg_data_filenamesinside apytest.mark.parametrizedecorator. With this PR,test -P wcsnow passes...