This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Repository navigation

Add support of configuring ConfigMaps with CR - #197

Merged

houshengbo merged 9 commits into

knative:masterfrom

houshengbo:pick-configmap

Apr 20, 2020

houshengbo commented Apr 20, 2020 •

edited

Loading

Issue to be fixed

This PR copied everything from serving-operator repository, to implement the Tranform for ConfigMaps.

Proposed Changes

This PR added a new field called config in eventing operator CR to support ConfigMap editing.

Release Note

mattmoor reviewed

View reviewed changes

googlebot added the cla: yes label

knative-prow-robot added the size/M label

knative-prow-robot requested review from Cynocracy and aliok

April 20, 2020 16:43

knative-prow-robot commented Apr 20, 2020

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [houshengbo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot added the approved label

knative-prow-robot reviewed

View reviewed changes

knative-prow-robot left a comment

Contributor

@houshengbo: 2 warnings.

Details

In response to this:

Issue to be fixed

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/reconciler/knativeeventing/common/config_maps.go

pkg/reconciler/knativeeventing/common/config_maps.go


          Add support of configuring ConfigMap with CR

c5f362e

houshengbo force-pushed the pick-configmap branch from 8bd0faf to c5f362e Compare

April 20, 2020 16:45


          Use 0.13.3 as the previous release version

a0c532f

knative-prow-robot added size/L and removed size/M labels

mattmoor reviewed

View reviewed changes

mattmoor left a comment

Member

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

Vincent and others added 5 commits

April 20, 2020 14:12


          Update pkg/reconciler/knativeeventing/common/config_maps_test.go

191553c

Co-Authored-By: Matt Moore <[email protected]>


          Update pkg/reconciler/knativeeventing/common/config_maps_test.go

aeca7c6

Co-Authored-By: Matt Moore <[email protected]>


          Update pkg/reconciler/knativeeventing/common/config_maps_test.go

26167d7

Co-Authored-By: Matt Moore <[email protected]>


          Update pkg/reconciler/knativeeventing/common/config_maps_test.go

7e0208a

Co-Authored-By: Matt Moore <[email protected]>


          Update pkg/reconciler/knativeeventing/common/config_maps_test.go

0ca138c

Co-Authored-By: Matt Moore <[email protected]>

mattmoor reviewed

View reviewed changes

mattmoor left a comment

Member

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor reviewed

View reviewed changes

mattmoor left a comment

Member

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor reviewed

View reviewed changes

mattmoor left a comment

Member

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor reviewed

View reviewed changes

mattmoor left a comment

Member

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

Vincent and others added 2 commits

April 20, 2020 14:13


          Update pkg/reconciler/knativeeventing/common/config_maps_test.go

382b6cc

Co-Authored-By: Matt Moore <[email protected]>


          Update pkg/reconciler/knativeeventing/common/config_maps_test.go

b5f8fd4

Co-Authored-By: Matt Moore <[email protected]>

mattmoor reviewed

View reviewed changes

mattmoor left a comment

Member

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

pkg/reconciler/knativeeventing/common/config_maps_test.go

Comment on lines +36 to +39

+              	name      string
+              	config    configMapData
+              	configMap corev1.ConfigMap
+              	expected  corev1.ConfigMap

mattmoor Apr 20, 2020

Member

Format Go code:

Suggested change

      
            	name      string
          
            	config    configMapData
          
            	configMap corev1.ConfigMap
          
            	expected  corev1.ConfigMap
          
            	name      string
          
            	config    configMapData
          
            	configMap corev1.ConfigMap
          
            	expected  corev1.ConfigMap

knative-metrics-robot commented Apr 20, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/knativeeventing/common/config_maps.go	Do not exist	92.3%

houshengbo changed the title ~~Add support of configuring ConfigMap with CR~~ Add support of configuring ConfigMaps with CR

houshengbo merged commit 8afd85c into knative:master

houshengbo pushed a commit to houshengbo/eventing-operator that referenced this pull request


          Add support of configuring ConfigMaps with CR (knative#197)

* Add support of configuring ConfigMap with CR

* Use 0.13.3 as the previous release version

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

Co-authored-by: Matt Moore <[email protected]>

houshengbo pushed a commit that referenced this pull request


          Add support of configuring ConfigMaps with CR (#197) (#198)

2c28a3a

* Add support of configuring ConfigMap with CR

* Use 0.13.3 as the previous release version

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

* Update pkg/reconciler/knativeeventing/common/config_maps_test.go

Co-Authored-By: Matt Moore <[email protected]>

Co-authored-by: Matt Moore <[email protected]>

Co-authored-by: Matt Moore <[email protected]>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved cla: yes size/L