Repository navigation
Fix KUBERNETES_MIN_VERSION propagation to operand workloads - #2245
Conversation
|
|
|
Welcome @eXist-FraGGer! It looks like this is your first PR to knative/operator 🎉 |
|
Hi @eXist-FraGGer. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
Bot
added
needs-ok-to-test
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@eXist-FraGGer: 0 warnings.
Details
In response to this:
Fixes #2233
Proposed Changes
- Add a common reconciler transformer that propagates
KUBERNETES_MIN_VERSIONfrom operator env to managed workloads.- Inject/override
KUBERNETES_MIN_VERSIONfor containers and initContainers inDeployment,StatefulSet,DaemonSet, andJobresources.- Wire the transformer into the shared transform pipeline and add unit tests for both injection and no-op behavior when the env var is unset.
Release Note
Fixes a regression where `KUBERNETES_MIN_VERSION` configured for the operator was not propagated to Knative Serving/Eventing workloads managed by the operator.Verification
go test ./pkg/reconciler/common -count=1passed.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
|
/ok-to-test Assigning to Vincent in case there's a simpler way of accomplishing this. Otherwise seems good to use a transformer /assign @houshengbo |
knative-prow
Bot
added
ok-to-test
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2245 +/- ##
==========================================
+ Coverage 63.45% 63.85% +0.39%
==========================================
Files 49 50 +1
Lines 1899 1953 +54
==========================================
+ Hits 1205 1247 +42
- Misses 600 605 +5
- Partials 94 101 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| for i := range podSpec.InitContainers { | ||
| mergeEnv(&minVersionEnv, &podSpec.InitContainers[i].Env) | ||
| } |
There was a problem hiding this comment.
I suggest to fill in the EphemeralContainers as well for debugging debugging/ephemeral containers, though they are not common to use:
// Add this to cover debugging/ephemeral containers
for i := range podSpec.EphemeralContainers {
mergeEnv(&minVersionEnv, &podSpec.EphemeralContainers[i].Env)
}
houshengbo
left a comment
houshengbo
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Based on the knative's perspective, it should have covered all resources. We need to pay attention later, especially when knative serving or eventing adds more resources like CronJob or Pod.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eXist-FraGGer, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
3 participants
Fixes #2233
Proposed Changes
KUBERNETES_MIN_VERSIONfrom operator env to managed workloads.KUBERNETES_MIN_VERSIONfor containers and initContainers inDeployment,StatefulSet,DaemonSet, andJobresources.Release Note
Verification
go test ./pkg/reconciler/common -count=1passed.