This repository was archived by the owner on Jun 24, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 24, 2020. It is now read-only.
The Image transformation is still missing the support of private secret #221
Description
Activity
/assign @garron
I've taken a look at adding this and it's pretty straightforward. However, it's worth pointing out that this will not result in the queue proxy in the various namespaces that ksvcs are deployed to using the imagePullSecrets.
As far as I can tell, there might not be a practical way to get the queue proxy using imagePullSecrets without changes to serving. Because the queue proxy runs in various namespaces, any imagePullSecrets would have to exist in those namespaces or be copied there.
I wrote up knative/serving#6075 to track next steps around getting imagePullSecrets working with the queue proxy.
Metadata
Metadata
Assignees
Labels
No labels
@garron As we discussed on slack, we probably need to verify if this support is missing for image transformation. If so, we will add it the same way as we did for the deployment transformation.