Repository navigation
Added reconciler test and updated deps - #232
Conversation
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@jihuin: 0 warnings.
Details
In response to this:
Proposed Changes
- Added reconciler test based on https://github.com/knative/serving/blob/master/pkg/reconciler/reconciler_test.go
- Updated deps by
dep ensureand./hack/update-deps.shRelease Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| "testing" | ||
|
|
||
| _ "knative.dev/pkg/client/injection/client/fake" | ||
| _ "knative.dev/pkg/client/injection/kube/client/fake" |
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
It might be worth minimizing the change to only the package needed for this test instead of updating all of them. i.e. "dep ensure -update knative.dev/pkg" Running ./update-deps.sh to update all of vendor/ should probably be isolated to its own PR to keep updating misc. packages and adding new feature/test code in independent commits that can be reverted without impacting each other. |
|
@anniefu The changes are all about adding fake clients that are required for the test. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jihuin, trshafer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 participants
Proposed Changes
dep ensureand./hack/update-deps.shRelease Note