Repository navigation
[13.x] Prevent loose comparisons in doesnt_contain validation rule - #61318
Merged
taylorotwell merged 1 commit intoAug 24, 2026
Merged
taylorotwell merged 1 commit into
taylorotwell merged 1 commit into
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
KIKOmanasijev
marked this pull request as ready for review
August 24, 2026 18:04
KIKOmanasijev
marked this pull request as draft
August 24, 2026 18:06
KIKOmanasijev
marked this pull request as ready for review
August 24, 2026 21:30
This was referenced Sep 8, 2026
binaryfire
added a commit
to hypervel/components-backup
that referenced
this pull request
Oct 1, 2026
Compare in_array and doesnt_contain values strictly and document their type-sensitive behavior. Retain contains behavior from the current upstream target. Port the remaining scalar in-rule cases, remove its obsolete documented difference, and consolidate contains/doesnt_contain tests under upstream file names. Preserve distinct existing assertions while restoring missing rule-formatting cases and adding strict-membership coverage. The validation suite and analysis pass. Upstream: laravel/framework#61146 laravel/framework#61315 laravel/framework#61319 laravel/framework#61318 Source: laravel/framework master 7068848dfe48fc3a433598e09ce798799d442a52.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
doesnt_containvalidation rule currently checks prohibited values with a loosein_array()comparison, so["0e123"]is treated as if it contains the prohibited value"0"and validation fails.#61146 fixed the same numeric-string comparison issue for the
inrule by enabling strict comparison. This applies that narrowly tovalidateDoesntContain()and adds regression coverage proving"0e123"passes while an exact"0"still fails. No other validation rules are changed.