Skip to content

win: fix reading hidden env vars - #2473

Closed
addaleax wants to merge 1 commit into
libuv:v1.xfrom
addaleax:fix-hidden-env-vars
Closed

addaleax wants to merge 1 commit into
libuv:v1.xfrom
addaleax:fix-hidden-env-vars

Conversation

@addaleax

Copy link
Copy Markdown
Contributor

There are some special environment variables on Windows that
start with a '=' sign, e.g. per-drive working directories.
In those cases, an initial '=' in the name of the environment
variable needs to be skipped when looking for the '=' that separates
it from its value.

There are some special environment variables on Windows that
start with a '=' sign, e.g. per-drive working directories.
In those cases, an initial '=' in the name of the environment
variable needs to be skipped when looking for the '=' that separates
it from its value.
@addaleax

Copy link
Copy Markdown
Contributor Author

@saghul

saghul commented Sep 13, 2019

Copy link
Copy Markdown
Member

Interesting! Do you have an example of how these look like? Also a link to some docs mentioning this would be most helpful.

@vtjnash vtjnash left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addaleax

Copy link
Copy Markdown
Contributor Author

Landed in fd1502f

@addaleax addaleax closed this Sep 17, 2019
addaleax added a commit that referenced this pull request Sep 17, 2019
There are some special environment variables on Windows that
start with a '=' sign, e.g. per-drive working directories.
In those cases, an initial '=' in the name of the environment
variable needs to be skipped when looking for the '=' that separates
it from its value.

PR-URL: #2473
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jameson Nash <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
@addaleax
addaleax deleted the fix-hidden-env-vars branch September 17, 2019 20:10
RaisinTen added a commit to RaisinTen/node that referenced this pull request Dec 13, 2020
The empty name check has been removed since this has landed:
libuv/libuv#2473
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Dec 15, 2020
The empty name check has been removed since this has landed:
libuv/libuv#2473

PR-URL: #36133
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Dec 21, 2020
The empty name check has been removed since this has landed:
libuv/libuv#2473

PR-URL: #36133
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request May 1, 2021
The empty name check has been removed since this has landed:
libuv/libuv#2473

PR-URL: #36133
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Jul 23, 2025
There are some special environment variables on Windows that
start with a '=' sign, e.g. per-drive working directories.
In those cases, an initial '=' in the name of the environment
variable needs to be skipped when looking for the '=' that separates
it from its value.

PR-URL: libuv/libuv#2473
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jameson Nash <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
liujinye-sys pushed a commit to open-vela/apps_system_libuv that referenced this pull request Dec 16, 2025
There are some special environment variables on Windows that
start with a '=' sign, e.g. per-drive working directories.
In those cases, an initial '=' in the name of the environment
variable needs to be skipped when looking for the '=' that separates
it from its value.

PR-URL: libuv/libuv#2473
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jameson Nash <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants