[v2]: drop support for old operating systems - #966
Conversation
|
|
||
| static void uv_cond_condvar_signal(uv_cond_t* cond) { | ||
| pWakeConditionVariable(&cond->cond_var); | ||
| /* nothing to do */ |
There was a problem hiding this comment.
Can you capitalize and punctuate the comment?
|
LGTM with a comment. Also down with dropping support for pre-VS 2015. One of the commits says "drop support for macOS < 10.9" but it looks like it's actually dropping support for < 10.7? |
See 2cfc286#diff-6a16903c26af4b4035eda9922a73ecc9L339 It will probably continue to compile, though with a warning. Same for 10.7, it would compile and run, but a test or 2 will fail. It's kinda more of a statement. I'll also update the README to reflect that. |
|
Nice! LGTM |
|
LGTM if it works :) |
a1b0cc1 to
4ba76a5
Compare
PR-URL: libuv#966 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
It's now present on all supported macOS and iOS versions. PR-URL: libuv#966 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
PR-URL: libuv#966 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
PR-URL: libuv#966 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
PR-URL: libuv#966 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
|
CI is 💚 for the relevant platforms. Game on! |
|
Btw, @piscisaureus if you have suggestions on things we could do better now that XP/2k3 support is not a concern, please let me know! |
4 participants
Time has come. I've come here to delete code and chew bubblegum. And I'm all out of bubblegum.
🔥 🔥 🔥 Windows XP 🔥 🔥 🔥
/cc @libuv/collaborators
I haven't tried to compile this yet, it's possible some includes are missing now that we call many functions directly instead of the dynamically loaded ones.
More improvements might be possible on Windows now that we drop the XP baggage, for example using CancelIoEx, but that's a story for another patch.
I also dropped support for MSVC < 2015, everyone just get with the program already.