Skip to content

Add TileFeature Type - #1429

Merged
echeipesh merged 8 commits into
locationtech:masterfrom
jamesmcclain:feature/ordered-tile
May 19, 2016
Merged

echeipesh merged 8 commits into
locationtech:masterfrom
jamesmcclain:feature/ordered-tile

Conversation

@jamesmcclain

@jamesmcclain jamesmcclain commented Mar 28, 2016 •

Copy link
Copy Markdown
Member

In this pull request the TileFeature[T, D] type is added.

Points to Examine

  • The TileFeature[T <: CellGrid,D: ? => BundleMethods[D]] type takes two type parameters, but the merge methods (in both raster and spark assume that T <: Tile. There are no assumptions on D other than it being a member of the bundle type class.
  • There is a question of range and precision of the data D. Right now they are treated as integer entities. Double versions are possible as well, but since one of the supported types of D is Seq[Tile], there is a question of how (best) to handle the situation when the data are mixed integers and floats.
  • I found that I had to add these secondary conversions from subclasses of BundleMethods[D] to BundleMethods[D] in order to get the constraints on TileFeatureMergeMethods to be satisfied. The issue seems to be that the Scala compiler does not look more than one layer deep when trying to satisfy these constraints. If there is a better way to handle this, I am open to it.

Still Need To

  • Provide Bundle Methods for Seq[Tile]
  • Provide Appropriate I/O support for TileFeatures
  • Provide Merge Methods for RDDs of TileFeatures
  • Move bundle methods to their own directory
  • Write ScalaDocs
  • Integrate Tests into PersistenceSpec

@jamesmcclain
jamesmcclain force-pushed the feature/ordered-tile branch from 42b1f43 to 2b3c42c Compare March 29, 2016 16:13
@jamesmcclain jamesmcclain changed the title [WIP] Add Ordered*Tile Types [WIP] Mar 30, 2016
@jamesmcclain
jamesmcclain force-pushed the feature/ordered-tile branch from 2b3c42c to a084067 Compare April 2, 2016 23:55
@jamesmcclain jamesmcclain changed the title [WIP] [WIP] Add TileFeature Type Apr 2, 2016
@jamesmcclain
jamesmcclain force-pushed the feature/ordered-tile branch 3 times, most recently from c09f39c to 00c325f Compare April 5, 2016 22:03
@jamesmcclain jamesmcclain changed the title [WIP] Add TileFeature Type Add TileFeature Type Apr 5, 2016
@jamesmcclain
jamesmcclain force-pushed the feature/ordered-tile branch 3 times, most recently from 0ec6d21 to 0c4c522 Compare April 11, 2016 22:38
@jamesmcclain
jamesmcclain force-pushed the feature/ordered-tile branch from 0c4c522 to cfc2edf Compare April 14, 2016 20:24
@jamesmcclain
jamesmcclain force-pushed the feature/ordered-tile branch 3 times, most recently from dd0c48b to dc7c7ee Compare April 17, 2016 03:31
@jamesmcclain
jamesmcclain force-pushed the feature/ordered-tile branch from 60aaec9 to c18d68c Compare May 3, 2016 16:13
import org.apache.spark.rdd._
import org.joda.time.DateTime

trait LayerUpdateSpaceTimeTileFeatureTests

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FunSpec, should be named Spec instead of Tests. Tests represents FunSuite tests.

@jamesmcclain jamesmcclain May 3, 2016 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I named this one after the file .../spark/io/LayerUpdateSpaceTimeTests.scala from which it was copied (same is true for .../spark/io/CoordinateSpaceTimeTileFeatureTests.scala and .../spark/io/AllOnesTestTileFeatureTests.scala). I can change the names of one or both of these sets of tests, if desired.

@lossyrob

lossyrob commented May 3, 2016

Copy link
Copy Markdown
Member

+1 after comments addressed

jamesmcclain added a commit to jamesmcclain/geotrellis that referenced this pull request May 3, 2016
@jamesmcclain

Copy link
Copy Markdown
Member Author

All comments have been addressed with the exception of the LayerUpdateSpaceTimeTileFeatureTests.scala naming issue which is discussed above.

@jamesmcclain

Copy link
Copy Markdown
Member Author

All comments have been addressed with the exception of the LayerUpdateSpaceTimeTileFeatureTests.scala naming issue which is discussed above.

Just to amplify, I am curious to know whether I should just change the names of the files that I added, or also change the name sof the files that they are based on.

@lossyrob

lossyrob commented May 9, 2016

Copy link
Copy Markdown
Member

The latter choice, change all the incorrect ones. Thanks.

@jamesmcclain

Copy link
Copy Markdown
Member Author

Okay, will-do.

@jamesmcclain
jamesmcclain force-pushed the feature/ordered-tile branch from fe2182a to b6fbc65 Compare May 10, 2016 18:52
@jamesmcclain

Copy link
Copy Markdown
Member Author

All comments prior to this one have been addressed.

@echeipesh
echeipesh merged commit 36bfa97 into locationtech:master May 19, 2016
@jamesmcclain
jamesmcclain deleted the feature/ordered-tile branch May 19, 2016 19:16
@lossyrob lossyrob added this to the 1.0 milestone Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants